Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 400522 - Constrain EMF repo to one specific /base repo so we know exactly what we are getting
Summary: Constrain EMF repo to one specific /base repo so we know exactly what we are ...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.2.1   Edit
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: 4.3 M6   Edit
Assignee: David Williams CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-12 00:55 EST by David Williams CLA
Modified: 2014-01-14 22:36 EST (History)
1 user (show)

See Also:


Attachments
patch to exclude incubator plugin (1.36 KB, patch)
2013-02-12 13:31 EST, David Williams CLA
no flags Details | Diff
remove-bundle.patch (526 bytes, patch)
2013-02-12 13:47 EST, Thanh Ha CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2013-02-12 00:55:09 EST
This was initially discussed in bug 398440, but "moved" here, since the original bug was a different topic. 
In short, we need to use a specific repo such as 

../modeling/emf/emf/updates/2.9milestones/base/S201212130932

to make sure we get exact version which, say, don't "suddenly channge" in a future build. 

But, if we try that now, and error occurs, because there is a rogue bundle in one of the repositories that gets built automatically even though we don't use it. 

Need to find a way to exclude it.
Comment 1 David Williams CLA 2013-02-12 08:58:16 EST
The "rogue bundle" to be removed from our builds, is org.eclipse.e4.ui.model.workbench.edit.


> [ERROR] Cannot resolve project dependencies:
> [ERROR]   Software being installed: org.eclipse.e4.ui.model.workbench.edit
> 0.11.0.qualifier
> [ERROR]   Missing requirement: org.eclipse.e4.ui.model.workbench.edit
> 0.11.0.qualifier requires 'bundle org.eclipse.emf.edit [2.6.0,3.0.0)' but it
> could not be found
> [ERROR]
> [ERROR] Internal error: java.lang.RuntimeException: "No solution found
> because the problem is unsatisfiable.": ["Unable to satisfy dependency from
> org.eclipse.e4.ui.model.workbench.edit 0.11.0.qualifier to bundle
> org.eclipse.emf.edit [2.6.0,3.0.0).", "No solution found because the problem
> is unsatisfiable."] -> [Help 1]
Comment 2 David Williams CLA 2013-02-12 13:31:47 EST
Created attachment 226942 [details]
patch to exclude incubator plugin

This is my best guess on how to exclude a bundle, that is in our repo, but, which we do not want to build. 

Which would then allow a specific URL to be specified for EMF dependency.
Comment 3 David Williams CLA 2013-02-12 13:34:30 EST
Thanh, I guess I can "just try it", but thought I'd CC you for review, if you have any better advice on how to exclude a bundle we don't want to build (but, happens to be in one of our repos). As far as I know, it's not actually being "pulled in" by any feature or pom, but is just being build because it happens to be there. 

Advise welcome.
Comment 4 Thanh Ha CLA 2013-02-12 13:46:56 EST
If org.eclipse.e4.ui.model.workbench.edit isn't needed to be built you can remove it from the root pom of the project [1].

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/pom.xml#n103
Comment 5 Thanh Ha CLA 2013-02-12 13:47:47 EST
Created attachment 226943 [details]
remove-bundle.patch

Patch to remove org.eclipse.e4.ui.model.workbench.edit
Comment 6 David Williams CLA 2013-02-12 14:18:15 EST
Paul, can you apply patch in comment 5 in platform ui? 

Then I could take back the bug to make releng changes.
Comment 8 David Williams CLA 2013-02-12 15:13:42 EST
Thank you.
Comment 9 David Williams CLA 2013-02-12 15:56:02 EST
http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=f149eb954332dde4ef22571fb2df6ef448f4682c

We should back port, IMHO, but will mark this bug fixed for Kepler.
Comment 10 David Williams CLA 2013-02-12 16:28:05 EST
Whoops. The commit in comment 9 "broke the build" because I copy/pasted wrong into Orbit's URL, instead of EMFs. 

This one undoes that typo, and corrects the EMF repo. 

http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=ea51c5b486d0bfccc1ce324264e29b4cb5b1eecf
Comment 11 David Williams CLA 2013-02-12 17:11:36 EST
Looks like there's lots of stuff from incubator being built. Trying a local build, I get errors below, so we may need to revert ... or (I'd prefer) take out all the incubator stuff, but, I don't now what that is off the top of my head.  



  1869 [ERROR] Cannot resolve project dependencies:
  1870 [ERROR]   Software being installed: org.eclipse.core.tools.feature.group 1.4.0.qualifier
  1871 [ERROR]   Missing requirement: org.eclipse.core.tools.feature.group 1.4.0.qualifier requires 'org.eclipse.core.tools.resource       s 0.0.0' but it could not be found
  1872 [ERROR]
  1873 [ERROR] Internal error: java.lang.RuntimeException: "No solution found because the problem is unsatisfiable.": ["Unable to sa       tisfy dependency from org.eclipse.core.tools.feature.group 1.4.0.qualifier to org.eclipse.core.tools.resources 0.0.0.", "Unab       le to satisfy dependency from org.eclipse.core.tools.feature.group 1.4.0.qualifier to org.eclipse.core.resources.spysupport 0       .0.0.", "No solution found because the problem is unsatisfiable."] -> [Help 1]
  1874 org.apache.maven.InternalErrorException: Internal error: java.lang.RuntimeException: "No solution found because the problem i       s unsatisfiable.": ["Unable to satisfy dependency from org.eclipse.core.tools.feature.group 1.4.0.qualifier to org.eclipse.co       re.tools.resources 0.0.0.", "Unable to satisfy dependency from org.eclipse.core.tools.feature.group 1.4.0.qualifier to org.ec       lipse.core.resources.spysupport 0.0.0.", "No solution found because the problem is unsatisfiable."]
Comment 12 David Williams CLA 2013-02-12 17:23:18 EST
I could be wrong about the source of the error ... perhaps its not this issue at all ... I was just assuming that 
org.eclipse.core.resources.spysupport
must depend on 
org.eclipse.e4.ui.model.workbench.edit
but do not know that. 

May be something else is wrong!?
Comment 13 David Williams CLA 2013-02-12 17:26:40 EST
(In reply to comment #12)
> I could be wrong about the source of the error ... perhaps its not this
> issue at all ... I was just assuming that 
> org.eclipse.core.resources.spysupport
> must depend on 
> org.eclipse.e4.ui.model.workbench.edit
> but do not know that. 
> 
> May be something else is wrong!?

yeah, don't think its this change that breaks things .... from the manifest. 

Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: Core Resource Management Spy Support Fragment
Bundle-SymbolicName: org.eclipse.core.resources.spysupport
Bundle-Version: 1.4.0.qualifier
Bundle-Vendor: Eclipse.org
Fragment-Host: org.eclipse.core.resources;bundle-version="[3.0.0,4.0.0)"
Export-Package: org.eclipse.core.internal.dtree;x-friends:="org.eclipse.core.tools.resources",
 org.eclipse.core.internal.properties;x-friends:="org.eclipse.core.tools.resources",
 org.eclipse.core.internal.resources;x-friends:="org.eclipse.core.tools.resources"
Bundle-RequiredExecutionEnvironment: J2SE-1.4
Comment 14 David Williams CLA 2013-05-30 16:45:16 EDT
mass change to 'verified', as these bugs are either routine or obviously fixed build breaks.