Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 400485 - [NLS] Add content types for JavaEE7 namespace
Summary: [NLS] Add content types for JavaEE7 namespace
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Rosendo Martinez CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard: JavaEE7 PMC
Keywords:
Depends on: 290019
Blocks: 400484
  Show dependency tree
 
Reported: 2013-02-11 15:01 EST by Carl Anderson CLA
Modified: 2013-05-02 11:19 EDT (History)
6 users (show)

See Also:
ccc: pmc_approved? (david_williams)
raghunathan.srinivasan: pmc_approved+
ccc: pmc_approved? (naci.dai)
neil.hauge: pmc_approved+
ccc: pmc_approved? (kaloyan)
ccc: pmc_approved? (cbridgha)
ccc: review+

Attachments
Proposed master patch (10.28 KB, patch)
2013-04-22 11:58 EDT, Rosendo Martinez CLA 		no flags Details | Diff
New Patch (10.52 KB, patch)
2013-04-23 10:11 EDT, Rosendo Martinez CLA 		shr31223: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carl Anderson CLA 2013-02-11 15:01:36 EST 
This will create new content types that cover the EE7 namespace... It will follow the same scheme the previous versions used.   Going through the Fast (QuickPeek) parse operation for reading XML headers....
Comment 1 Rosendo Martinez CLA 2013-04-22 11:58:52 EDT 
Created attachment 229979 [details]
Proposed master patch

Here there are some changes to support EE7 contentypes.

Some questions:

1. What's the Web Fragment version in EE7?
2.Is this OK? public final static QualifiedName JEEVERSION = new QualifiedName("jee-version", "5.0"); is 5.0. The version 5.0 is still in JEE6ContentDescriber
3. Should the ResourceFactories classes be modified or create new ones for EE7?
Comment 2 Carl Anderson CLA 2013-04-22 16:59:25 EDT 
1) Web Fragment version for Java EE 7 is 3.1 (same as Web)

2) That looks like a bug on the JEE6ContentDescriber.  Make it 7.0

3) Modifying the Javaee ones should be sufficient
Comment 3 Rosendo Martinez CLA 2013-04-23 10:11:04 EDT 
Created attachment 230022 [details]
New Patch
Comment 4 Carl Anderson CLA 2013-04-30 16:52:06 EDT 
PMC Review requested due to UI change

We are adding several string in to org.eclipse.jst.jee/plugin.properties

Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such.

This is needed to help finalize our support of Java EE 7.

Is there a work-around? If so, why do you believe the work-around is insufficient?

There is no work-around.  This is all new support for Java EE 7.  This adds in the same Content Types and ContentDescriber for Java EE 7 that were added in for Java EE 6.

How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added?

The Java EE Tools JUnit bucket has been run against this fix.  Furthermore, it has been tested as part of the work for bug 400484

Give a brief technical overview. Who has reviewed this fix?

This adds in the same Content Types and ContentDescriber for Java EE 7 that were added in for Java EE 6.  Carl Anderson has reviewed this fix.

What is the risk associated with this fix? 
Relatively low
Comment 5 Roberto Sanchez Herrera CLA 2013-05-01 16:59:40 EDT 
Committed http://git.eclipse.org/c/jeetools/webtools.javaee.git/commit/?id=5e2b4349a92be2a625eb72237c69cef44e027b49

And released using tag v201305012100 to WTP 3.5

Note that I did not commit the change to MANIFEST.MF, because the version of the plugin had been already updated for WTP 3.5