Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 400227 - Unexternalized strings on Navigator page
Summary: Unexternalized strings on Navigator page
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 2.0 RC2   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-07 11:01 EST by Kit Lo CLA
Modified: 2013-02-12 11:57 EST (History)
1 user (show)

See Also:
malgorzata.tomczyk: review+

Attachments
Navigator (17.50 KB, image/png)
2013-02-07 11:01 EST, Kit Lo CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kit Lo CLA 2013-02-07 11:01:13 EST 
Created attachment 226707 [details]
Navigator

I believe the strings in red box are unexternalized.
Comment 1 Susan McCourt CLA 2013-02-07 14:33:06 EST 
These are unexternalized strings in the pageLinks plugin.
We need code in table.js that looks for the NLS key, though.
Comment 2 Susan McCourt CLA 2013-02-11 15:23:59 EST 
Gosia, can you review/push this please?

branch is bug400227
commit is
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?h=bug400227&id=0b23498a6f094cd356faeb2881379c3bc13f4422
Comment 3 Malgorzata Janczarska CLA 2013-02-12 11:57:46 EST 
(In reply to comment #2)
> Gosia, can you review/push this please?
> 
> branch is bug400227
> commit is
> http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/
> ?h=bug400227&id=0b23498a6f094cd356faeb2881379c3bc13f4422

Uff... it requires cleaning cache, reloading plugins and cleaning localStorage to get it all updated, but then works like a charm.

Thanks Susan, merged.