Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 400121 - FileExplorer should have template/data binding for showing file information
Summary: FileExplorer should have template/data binding for showing file information
Status: RESOLVED WONTFIX
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 403483
  Show dependency tree
 
Reported: 2013-02-06 11:30 EST by Susan McCourt CLA
Modified: 2015-05-05 14:51 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2013-02-06 11:30:13 EST
The FileExplorer is used by the Navigator and DirectoryPrompter (and possibly elsewhere) but we always assumed that someone would create their own renderer if they didn't want the navigator style.  

However, the project navigation wants all of the first column part of NavigatorRenderer (links, open with, etc.) but doesn't want the rest of it.

To do this, I had to add a couple of properties to the renderer that the NavigatorRenderer checks to decide what to do.  That way, the projects renderer could override it.  I just couldn't stand copying all the code from the NavigatorRenderer.

This will need to get sorted out at a later time, but I wanted to record it now.

renderer.folderLink is a property that is used to preface the folder address, such as the navigator page.  If not specified,the current page URL used.  This was needed so that the project page didn't try to hash on the file in its drive tree.

renderer.oneColumn is a property used to specify that only one column is needed.

Both of these are pretty subtle and hacky, but it's RC1 week.
I think the navigator renderer should be reconsidered in general.  Ideally we could just template the renderer as needed and it would do the right thing.
Comment 1 Susan McCourt CLA 2013-02-06 11:31:32 EST
We should probably also rename "explorer-table" to "FileExplorer"

The old name referred to the fact that it was the explorer for table.js.
Now that it's trying to be more general, we should rename it.  I keep finding myself trying to open "FileExplorer" and forgetting the name of the file.
Comment 2 Susan McCourt CLA 2013-03-15 12:18:02 EDT
Renaming bug.

Basically, the NavigatorRenderer (or perhaps more appropriately called FileRenderer) should support some known variables, like
${Date} ${Name} ${Location} ${Icon} etc....

Then clients could build a description of a row like...

<tr><td>${Icon}${Name}</td><td>${Date}</td></tr>

or whatever.

Note that this is not just simple text substitution, some of the variables need dynamic behaviors (like icons that look up the content type, or hrefs that need the OrionHome variable, etc.)

We might even want to support URI templating of the location itself.
Comment 3 John Arthorne CLA 2015-05-05 14:51:39 EDT
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:

https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html