Community
Participate
Working Groups
Our product (IBM Installation Manager) has one perspective with a stand-alone view. In the ViewPart.setFocus(), we set the help id by using: public void setFocus() { PlatformUI.getWorkbench().getHelpSystem().setHelp(this.getSite().getShell(), getHelpRef()); //.... } But ViewPart.setFocus() is called in 'page.setPerspective(perspective)' in WorkbenchWindow.setup(): public void setup() { //... page.setPerspective(perspective); //... workbench.getHelpSystem().setHelp(getShell(), IWorkbenchHelpContextIds.WORKBENCH_WINDOW); //... } And later one, the help id for our product shell was overriden by workbench.getHelpSystem().setHelp(getShell(), IWorkbenchHelpContextIds.WORKBENCH_WINDOW); as you can see from WorkbenchWindow.setup(). This is a regression from Eclipse 4.2.1 adoption.
Created attachment 226624 [details] Move setting the help system I can move the help system linking up to a similar position in the setup() method (before the perspective is set/fired). Does this patch help? Also, how do I activate something that will show help for this shell, so I can make sure it doesn't break anything? PW
I think this patch will fix the problem. Not sure if I understand your question of 'Also, how do I activate something that will show help for this shell, so I can make sure it doesn't break anything?'. Our product displays the stand-alone view in the Shell and when user presses F1 button, WorkbenchHelpSystem.displayContext(IContext, int, int) would be called to display the CS help.
When will the fix be delivered?
I don't have a reproducible scenario in the eclipse SDK yet to prove it fixes something. PW
Is there anything I can help to make this problem fixed in the next release of eclipse? Thanks.
(In reply to comment #5) > Is there anything I can help to make this problem fixed in the next release > of eclipse? Thanks. I still need a test that fails before the patch but works afterwards. PW
Is a simple RCP ok? I can try to extract some of our product's plugins into a test. Thanks.
Yes, if you had a simple RCP example plugin that would be great. PW
Created attachment 233813 [details] Test plugin for the problem Here is a RCP plugin to use to re-produce the problem. 1. To see the problem, you need to clear the workspace. 1) if you set a break point at 'setFocus()' for the View, it will be hit first. 2) then in 'WorkbenchWindow.setup()': ..... workbench.getHelpSystem().setHelp(getShell(), IWorkbenchHelpContextIds.WORKBENCH_WINDOW); would be hit later. 2. Another problem is also detected with this plugin: 1) if you don't clear the workspace, re-use the perspective opened in the last session, launch this plugin, this problem won't occur. 2) after the View is open, hit F1 button, the help would be displayed on the right hand side correctly. 3) Click on anything in the View, the help would be changed to Eclipse workbench help, which is not correct.
(In reply to comment #9) > Created attachment 233813 [details] > Test plugin for the problem Thanks for the test plugin. Fix released as http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d731b6c381d06a8e796f2a035d75a959e1813d79 PW
Moving to M2 as per bug 414630 comment 4.
released. PW
In 4.4.0.I20130806-2000 PW
