Community
Participate
Working Groups
Build: I-20030710 Decorators are behaving oddly in this build. First, when I launch Eclipse, they do not appear. I have to do an explicit action, such as open a file for them to appear. Second, as you can see in the attached screenshot, after synchronizing files with the repository, some of the files lost the CVS label decorator.
Created attachment 5436 [details] missing CVS decorators
This was a problem with lost updates when there were no windows. Fixed for M2.
Marking fixed
Build: I-20030715 The first problem (i.e. decorators do not automatically appear when I launch Eclipse) has been fixed. The second problem though (i.e. some files lose the CVS decorator after synchronizing) is occurring much less frequenly, but still occurring nevertheless. I have the Live Synchronize view open, the Package explorer view open, and one Java file open: every time I make a modification to the file and save. The file in the Package explorer sometimes loses the decorator and sometimes it retains it. It's pretty random.
I can't replicate this in 20030717 but I am going to keep this open as a precaution. Please let me know if the problem persists. Also be aware that if using the Synch View it has a higher priority than decorators and they may not be run until after the Synchonize is done.
I'm still encountering it in the I-20030717(2359) driver. This time the synchronize view was not even open. I saved a Java file and the CVS decorator vanished. Once I opened the synchronize view, the UI refreshed, and the decorator reappeared.
Adding Jean-Michel to the list - this does not appear to be a general problem with the decorators mechanism but rather an issue with the CVS Decorator not getting a result in some cases. I have been able to replicate this problem after a save which ends up sending updates from both the CVS decorator and the resource change listener in the packages view but all this should cause is a superfluous extra decoration.
I have replicated this without the CVS decorator so this is a general problem. Removing Jean-Michel from the cc list.
*** Bug 40575 has been marked as a duplicate of this bug. ***
This was due to updates being lost due to releasing the result lock before the job had finished scheduling. It was indeed a timing issue. I have released a fix into build >20030722 but will keep this PR open as it has been a toughie thus far.
*** Bug 40458 has been marked as a duplicate of this bug. ***
CVS decorators still don't show up for some items using I20030723
Dani do you have a specific set of steps to replicate this? The problem is usually timing specific so it tends to be certain actions that cause this to occur.
Added Dani in order to get more info
I see this while using Java Browsing perspective. See attached picture.
Created attachment 5578 [details] Picture of missing decorators in Java Browsing perspective
This looks like the same problem with missing updates as we had before. I have made another pass over the code and found some more potential problems that I have fixed up but I would feel better if I could replicate the issue. Where you doing any CVS related operations while doing this? Or just editing and saving?
If I open a type using the setup in attached image, then edit and save, the decorators disappear.
I have replicated this in the Java browsing perspective the same way - thanks.
Closing this report. The lost update problem has been handled by keeping track of whether or not the last request was served.
Things have been fine for a couple of weeks. But today as I launch I-20030813, my CVS decorators are not showing up, although the CVS checkbox is indeed selected in the preferences.
Created attachment 5772 [details] pde.ui is lacking CVS decorators
I just noticed in my stack trace that the team cvs plug-in has failed to start due to some circularity errors. So I'll open a defect against them, as this would explain the lack of decorators. (I can hear Tod's sigh of relief all the way from T.O. :-)
