This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 399805 - Support refactor->Rename from right click menu in js file.
Summary: Support refactor->Rename from right click menu in js file.
Status: REOPENED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: VJET (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Jack Liu CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 401482 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-02-03 07:11 EST by Jack Liu CLA
Modified: 2017-04-11 15:12 EDT (History)
1 user (show)

See Also:


Attachments
Uncomment refactor menu gropu (2.84 KB, patch)
2013-02-03 07:13 EST, Jack Liu CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jack Liu CLA 2013-02-03 07:11:47 EST
Support refactor -> rename.
It is similar to JDT's rename feature.
Comment 1 Jack Liu CLA 2013-02-03 07:13:31 EST
Created attachment 226478 [details]
Uncomment refactor menu gropu

Only need to uncomment refactor action group.
Comment 2 Justin Early CLA 2013-02-07 20:16:21 EST
After merge in noticing this in error logs


!ENTRY org.eclipse.jface 4 0 2013-02-07 17:15:27.952
!MESSAGE The command ("org.eclipse.dltk.mod.ui.edit.text.script.rename.element") is undefined
!STACK 0
java.lang.Exception
	at org.eclipse.jface.action.ExternalActionManager$CommandCallback.isActive(ExternalActionManager.java:370)
	at org.eclipse.jface.action.ActionContributionItem.isCommandActive(ActionContributionItem.java:647)
	at org.eclipse.jface.action.ActionContributionItem.isVisible(ActionContributionItem.java:703)
	at org.eclipse.jface.action.MenuManager.isChildVisible(MenuManager.java:1004)
	at org.eclipse.jface.action.MenuManager.isVisible(MenuManager.java:572)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer.reconcileManagerToModel(MenuManagerRenderer.java:820)
	at org.eclipse.ui.internal.PopupMenuExtender.addMenuContributions(PopupMenuExtender.java:405)
	at org.eclipse.ui.internal.PopupMenuExtender.menuAboutToShow(PopupMenuExtender.java:379)
	at org.eclipse.jface.action.MenuManager.fireAboutToShow(MenuManager.java:343)
	at org.eclipse.jface.action.MenuManager.handleAboutToShow(MenuManager.java:475)
	at org.eclipse.jface.action.MenuManager.access$1(MenuManager.java:470)
	at org.eclipse.jface.action.MenuManager$2.menuShown(MenuManager.java:500)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:255)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4134)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1458)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1481)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1462)
	at org.eclipse.swt.widgets.Menu.menuWillOpen(Menu.java:806)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:5547)
	at org.eclipse.swt.internal.cocoa.OS.objc_msgSend(Native Method)
	at org.eclipse.swt.internal.cocoa.NSMenu.popUpContextMenu(NSMenu.java:77)
	at org.eclipse.swt.widgets.Menu._setVisible(Menu.java:278)
	at org.eclipse.swt.widgets.Display.runPopups(Display.java:4057)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3612)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1029)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:923)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:86)
	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:588)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:543)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:353)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:180)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:629)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:584)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1438)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1414)
Comment 3 Jack Liu CLA 2013-02-23 04:06:44 EST
Fixed:
git.exe push --progress  "origin" b_399805:b_399805

Solution:
Need open the action definition in plugin.xml

Location:
/gitroot/vjet/org.eclipse.vjet.dltk.git
Comment 4 Jack Liu CLA 2013-02-23 04:09:21 EST
Reopen until it was verified.
Comment 5 Jack Liu CLA 2013-02-23 06:58:16 EST
*** Bug 401482 has been marked as a duplicate of this bug. ***