Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 399745 - Support e3 and e4 RCP application testing with single bundle
Summary: Support e3 and e4 RCP application testing with single bundle
Status: CLOSED FIXED
Alias: None
Product: Jubula
Classification: Technology
Component: RC (show other bugs)
Version: unspecified   Edit
Hardware: All Linux
: P3 normal (vote)
Target Milestone: Kepler   Edit
Assignee: Raimar Bühmann CLA
QA Contact: Oliver Goetz CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 379217 397856 398618 400654
  Show dependency tree
 
Reported: 2013-02-01 12:11 EST by Raimar Bühmann CLA
Modified: 2013-02-21 10:01 EST (History)
2 users (show)

See Also:

Attachments
Support RCP applications with one bundle (e3 and e4) (363.69 KB, patch)
2013-02-01 12:11 EST, Raimar Bühmann CLA 		no flags Details | Diff
Update including Buddy Classloading (1.26 KB, patch)
2013-02-04 07:05 EST, Raimar Bühmann CLA 		no flags Details | Diff
Update including NLS tags (4.68 KB, patch)
2013-02-05 06:37 EST, Raimar Bühmann CLA 		no flags Details | Diff
Update including correct qualifiers (111.65 KB, patch)
2013-02-07 04:49 EST, Raimar Bühmann CLA 		no flags Details | Diff
Support RCP applications with one bundle (e3 and e4) (443.16 KB, patch)
2013-02-07 05:45 EST, Raimar Bühmann CLA 		no flags Details | Diff
Support RCP applications with one bundle (e3 and e4) (444.74 KB, patch)
2013-02-07 06:31 EST, Raimar Bühmann CLA 		no flags Details | Diff
Support RCP applications with one bundle (e3 and e4) (445.14 KB, patch)
2013-02-07 11:59 EST, Raimar Bühmann CLA 		no flags Details | Diff
Support RCP applications with one bundle (e3 and e4) (modified after review) (435.39 KB, patch)
2013-02-11 03:24 EST, Raimar Bühmann CLA 		markus.tiede: iplog+
Details | Diff
BUGFIX: RCP accessor: Fixed infinite loop in setToolbarComponentName() (1.20 KB, patch)
2013-02-12 05:19 EST, Raimar Bühmann CLA 		markus.tiede: iplog+
Details | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raimar Bühmann CLA 2013-02-01 12:11:17 EST 
Created attachment 226462 [details]
Support RCP applications with one bundle (e3 and e4)

The attached patch includes the modifications for the Jubula accessor in RCP AUT applications needed for testing:

* Support for e3 and e4 RCP applications in one base bundle named "org.eclipse.jubula.rc.rcp".
* The following bundles, which are included in the base bundle, are installed programmatically with OSGI depening on the running Eclipse version e3 or e4 (with and without compatibility layer):
  * org.eclipse.jubula.rc.rcp.common for e3 and e4
  * org.eclipse.jubula.rc.rcp.swt for e3 and e4 with SWT
  * org.eclipse.jubula.rc.rcp.e3 for e3
  * org.eclipse.jubula.rc.rcp.e3.specific for e3
  * org.eclipse.jubula.rc.rcp.e4 for e4
  * org.eclipse.jubula.rc.rcp.e4.swt for e4 with SWT
Comment 1 Raimar Bühmann CLA 2013-02-04 03:07:42 EST 
Added blocking BUG IDs depending on this BUG.
Comment 2 Raimar Bühmann CLA 2013-02-04 07:05:54 EST 
Created attachment 226499 [details]
Update including Buddy Classloading

This patch adds needed Buddy Classloading for Jubula commands send to the accessor.
Comment 3 Raimar Bühmann CLA 2013-02-05 06:37:42 EST 
Created attachment 226559 [details]
Update including NLS tags
Comment 4 Raimar Bühmann CLA 2013-02-07 04:49:00 EST 
Created attachment 226679 [details]
Update including correct qualifiers

This patch enhances the build to add correct qualifiers to the bundle file names, which are installed by org.eclipse.jubula.rc.rcp
Comment 5 Raimar Bühmann CLA 2013-02-07 05:45:56 EST 
Created attachment 226683 [details]
Support RCP applications with one bundle (e3 and e4)

This patch includes the previously added patches.
Comment 6 Raimar Bühmann CLA 2013-02-07 06:31:24 EST 
Created attachment 226688 [details]
Support RCP applications with one bundle (e3 and e4)

This patch includes the previous ones and fixes build problems (SWT library has not been build).
Comment 7 Markus Tiede CLA 2013-02-07 09:03:31 EST 
Reviewing enhancement patch(es).
Comment 8 Raimar Bühmann CLA 2013-02-07 11:59:05 EST 
Created attachment 226718 [details]
Support RCP applications with one bundle (e3 and e4)

With correct build dependencies.
Comment 9 Markus Tiede CLA 2013-02-08 04:32:45 EST 
The attached patch requires additional adjustments:
 - the following classes have too many similarities
  - org.eclipse.jubula.rc.rcp.swt.aut.RcpSwtComponentNamer
  - org.eclipse.jubula.rc.rcp.e3.accessor.E3Startup
 - some classes contain commented-out source code fragments e.g. org.eclipse.jubula.rc.rcp.swt.aut.SwtRemoteControlService line 71f
 - the code contains FIXMEs e.g. in org.eclipse.jubula.rc.rcp.swt.aut.RcpSwtComponentNamer line 277
 - there are a few too many .keep files e.g. 
  - org.eclipse.jubula.rc.rcp.e3.specific/src/.keep
  - org.eclipse.jubula.rc.rcp.e4/src/.keep
  - ...

Please resolve these issues and re-contribute.
Comment 10 Achim Loerke CLA 2013-02-11 03:18:13 EST 
@Triaged:+

Just to remove this from the "needs triage" list.
Comment 11 Raimar Bühmann CLA 2013-02-11 03:24:36 EST 
Created attachment 226820 [details]
Support RCP applications with one bundle (e3 and e4) (modified after review)
Comment 12 Raimar Bühmann CLA 2013-02-12 05:19:41 EST 
Created attachment 226907 [details]
BUGFIX: RCP accessor: Fixed infinite loop in setToolbarComponentName()

The attached patch is a bugfix for an infinite loop in the method setToolbarComponentName() of the class RcpSwtComponentNamer. This bug only exists in the RCP accessor for e3.x applications not running in compat layer mode.
Comment 14 Oliver Goetz CLA 2013-02-21 10:01:46 EST 
Tested. I was able to start an Eclipse version 3.4 and our current CaA RCP 4.2 e4 AUT using the same bundle. Closing this ticket.