Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 399543 - [GTK3] Replace GtkColorSelection with GtkColorChooser for GTK 3.4 and up
Summary: [GTK3] Replace GtkColorSelection with GtkColorChooser for GTK 3.4 and up
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.3   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.3 M6   Edit
Assignee: Arun Thondapu CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 340067
  Show dependency tree
 
Reported: 2013-01-30 14:51 EST by Anatoly Spektor CLA
Modified: 2013-02-07 05:22 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anatoly Spektor CLA 2013-01-30 14:51:00 EST 
This patch replaces GtkColorSelection with GtkColorChooser for GTK 3.4 and higher:

http://fedorapeople.org/cgit/aspektor/public_git/eclipse.platform.swt.git/commit/?h=gtk_color_chooser
Comment 1 Alexander Kurtakov CLA 2013-02-06 14:15:07 EST 
I reviewed and tested the patch and I'm happy with it. Let me know if someone else objects otherwise I'll apply it.
Comment 2 Arun Thondapu CLA 2013-02-07 05:20:27 EST 
Hi Alex, Sorry for the overlap!

I was testing the patch myself and have just pushed it with a few formatting changes and a bug that I found and fixed (the existing choice of color, if any, was being ignored while opening the color chooser dialog).

http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=93a94094191ba6bab3d01c83b707e1431df666a6

http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=f657532d209472f8fafec3d965f8dc7f35b5af06

http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=fa723f28f2f267e5615bfd54cf2b83f638a4dc96

Hope I've not missed anything...
Comment 3 Alexander Kurtakov CLA 2013-02-07 05:22:26 EST 
Thanks for applying it.