Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 399458 - Layout overlap in line-wrapped trim bar
Summary: Layout overlap in line-wrapped trim bar
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2.1   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.3 M6   Edit
Assignee: Eric Moffatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-30 03:17 EST by Christian Walther CLA
Modified: 2013-03-12 13:20 EDT (History)
4 users (show)

See Also:


Attachments
proposed patch (2.38 KB, patch)
2013-01-30 03:20 EST, Christian Walther CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Walther CLA 2013-01-30 03:17:42 EST
When a trim bar contains so many items that they are wrapped onto multiple lines, any spacer item, such as the StatusLine in the bottom trim, is erroneously given the whole height of the trim instead of the height of its line, so that it overlaps the items on the next line.

Steps to reproduce:
1. Focus a text editor so that some visible content appears in the status line.
2. Start a lengthy operation, e.g. a check for updates, so that some visible content appears in the progress region.
3. Make the window so narrow that the trim wraps onto two lines.

Actual result:
The progress region disappears and the status line is inflated to double height.

Expected result:
The progress region should appear below the status line, both at their normal height.

This is fixed by the attached patch.

As a side effect, it also fixes bug 389941 for the case of a wrapped bar (which the original fix didn’t).
Comment 1 Christian Walther CLA 2013-01-30 03:20:09 EST
Created attachment 226297 [details]
proposed patch
Comment 2 Eric Moffatt CLA 2013-02-07 14:36:37 EST
Thanks Christian ! I'll take a look at the patch on Monday (first of our 'patch days'..;-).
Comment 3 Eric Moffatt CLA 2013-02-11 13:20:02 EST
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=5d257381db57a05fe00b8e484c53d67a78dd2a01

Applied Christian's patch...thanks, looks great now !
Comment 4 Christian Walther CLA 2013-02-12 11:06:20 EST
Thanks!
Comment 5 Curtis Windatt CLA 2013-03-12 13:20:37 EDT
Verified in I20130312-1000