Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 398992 - Dialog buttons can't be activated with spacebar
Summary: Dialog buttons can't be activated with spacebar
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 2.0 M2   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-24 12:02 EST by Mark Macdonald CLA
Modified: 2013-01-24 13:20 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2013-01-24 12:02:41 EST 
1. Go to the Sites page
2. Create a new site, and edit it
3. Click "Convert to self hosting" to bring up a dialog
4. Click Browse, select some folder, and OK out of the browse dialog.
5. Now in the remaining dialog, Tab to the OK button and try to activate it by pressing SPACE. I expected it to fire the button, but it doesn't.

ENTER does work, however.
Comment 1 Susan McCourt CLA 2013-01-24 13:20:45 EST 
There was a typo in the common code (checking charCode instead of keyCode).  And unfortunately this has been copied all over the place.

I have bigger problems to fix for M2, so I just fixed all the places and will refactor more properly in RC1 in bug 399004.

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=fc3f900b17e262fd76610097012b022daa8e6ba1