Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 398631 - Menu item missing icon from commandImages
Summary: Menu item missing icon from commandImages
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2.1   Edit
Hardware: PC Windows 7
: P3 minor (vote)
Target Milestone: 4.3 M6   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-21 08:42 EST by Christian Walther CLA
Modified: 2013-03-12 13:43 EDT (History)
1 user (show)

See Also:

Attachments
Reproducing example plugin (source + binary) (3.70 KB, application/zip)
2013-01-21 08:42 EST, Christian Walther CLA 		no flags Details
proposed patch (2.94 KB, patch)
2013-01-21 08:47 EST, Christian Walther CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Walther CLA 2013-01-21 08:42:47 EST 
Created attachment 225883 [details]
Reproducing example plugin (source + binary)

When a command menu item has no icon specified in its org.eclipse.ui.menus extension, but the command it invokes has one provided by an org.eclipse.ui.commandImages extension, and in addition the menu item has an explicit ID that is not equal to the command ID, the icon is not shown in the menu.

Steps to reproduce:
Build or install the attached example plugin.

Expected result:
Item “Hello World” in menu “Hello” should display an icon.

Actual result:
The menu item has no icon.

I can fix this using the attached patch.
Comment 1 Christian Walther CLA 2013-01-21 08:47:21 EST 
Created attachment 225886 [details]
proposed patch
Comment 3 Christian Walther CLA 2013-02-12 11:06:56 EST 
Thanks! I agree with the simplification you did, I just did it that way in analogy to the code in createToolBarCommandAddition().
Comment 4 Paul Webster CLA 2013-03-12 13:43:28 EDT 
In 4.3.0.I20130311-2000

PW