Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 397739 - Compile warning in official build
Summary: Compile warning in official build
Status: VERIFIED DUPLICATE of bug 378024
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 4.3   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 4.3 M5   Edit
Assignee: Stephan Herrmann CLA
QA Contact:
URL: http://download.eclipse.org/eclipse/d...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-09 03:12 EST by Dani Megert CLA
Modified: 2013-02-04 11:00 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2013-01-09 03:12:46 EST
N20130108-2000

ImportRewriteAnalyzer.java (at line 274):
int nextExtendedOffsetLine = root.getLineNumber(nextExtendedOffset);
The value of the local variable nextExtendedOffsetLine is not used

Caused by fix for bug 378024.
Comment 1 Stephan Herrmann CLA 2013-01-09 13:08:21 EST
Considering that I complained about this very local variable during code review, I need to check whether I actually committed the right change (later today).
Comment 2 Stephan Herrmann CLA 2013-01-09 19:59:58 EST
At a closer look this issue was already identified during code review, see bug 378024 comment 13:
> > Some changes in addExistingImports() seem to be obsolete.
> I do see a redudnant variable nextExtendedOffsetLine, but not sure exactly what others are. 

This surfaced in the official build only because I pushed the wrong change, sorry!

To be finalized in bug 378024 (re-opened).

*** This bug has been marked as a duplicate of bug 378024 ***
Comment 3 Jay Arthanareeswaran CLA 2013-02-04 11:00:32 EST
Verified for 4.3 M5 with build I20130130-2000