Community
Participate
Working Groups
I have created an extension for the External Tools Framework that allows users to write JAXB workflows using the UI widgets provided by PTP's resource manager schema. This allows more direct control over the User Interface design for ETFw tools. The framework supports both the previous SAX parser based workflows and the new JAXB parser based workflow using a menu selection in the Performance Analysis tab. There are minor changes to the ETFw backend to support both workflow types.
Created attachment 225344 [details] patches to ETFw
Created attachment 225345 [details] new projects for ETFw
There are notes in the ETFW schema explaining why it points at my local workspace for importing the resource manager schema. In short, the ETFw TAU patch in bug 397685 needs the modified resource manager schema to work properly. If these changes are accepted and made to the schema at http://eclipse.org/ptp/schemas/rm.xsd then the ETFw schema will simply need to be pointed there.
Chris, please make the following confirmations: 1. I authored 100% of the content I'm contributing 2. I have the rights to contribute the content to Eclipse 3. I contribute the content under the EPL' Thanks!
Created attachment 227096 [details] patches to support new etfw framework
Created attachment 227097 [details] projects for new etfw framework
1) I have authored 100% of the content I am contributing. 2) I have the rights to contribute the content to Eclipse 3) I contribute the content under the EPL. All contributed classes should include a header stating this as well. (In reply to comment #4) > Chris, please make the following confirmations: > > 1. I authored 100% of the content I'm contributing > 2. I have the rights to contribute the content to Eclipse > 3. I contribute the content under the EPL' > > Thanks!
Some comments about the latest (2/14/2013) projects 1. In the org.eclipse.ptp.etfw.launch project plugin requires JavaSE-1.7 and should be reset to use JavaSE-1.6. 2. In the org.eclipse.ptp.etfw.launch project plugin in the ETFWToolTabBuilder class getting an "Unhandled exception type CoreException" for two lines: UpdateModelFactory.createModel(control, browse, tab, rmVarMap, targets);
This contribution has now been approved.
This has been committed to master. I noticed a few issues with the contribution: 1. There is a lot of commented out code. Please remove. 2. There are non-externalized strings. Please run the Externalize Strings and Find Broken Exernalized Strings wizards. 3. Raw types are used. These should be parameterized. 4. Plugin missing about.html. 5. Plugin localization needs to be plugin and plugin.properties added. 6. Plugins missing pom.xml files. 7. Plugins need to be added to feature. If you could attach a patch that address these issues it would be appreciated. Thanks!
I'll do that.
I don't see the new classes from the org.eclipse.ptp.etfw.patch that should be in org.eclipse.ptp.etfw. There was an ETFWBuilderTool, ETFWToolStep, ETFWLaunchTool and ETFWPostProcessTool. These are the pieces that understand the jaxb ETFW workflow.
I had to apply some of the patches by hand and missed these. I've applied the etfw and etfw.parallel patches now. Please check they are ok.
Created attachment 228111 [details] addresses code cleanup This should address all code cleanup issues identified in comment #10. I also noticed some un-implemented methods in ETFWLaunchTabBuilder that required 2 more x-friends to support building all JAXB widget types and remove discouraged access warnings. The x-friends patch is part of the org.eclipse.ptp.rm.jaxb.control.ui.patch. We can discuss in more detail later, but basically LaunchTabBuilder is specific to the target configuration launch tabs, which is why I had to create ETFWLaunchTabBuilder. In the future I think we should be able to use a single launch tab builder. Should I open a bug on this?
I applied the patch, but I'm seeing a reference to IToolLaunchConfigurationConstants.USE_JAXB_PARSER which doesn't seem to exist. Also, rather than a tar.gz, please just add a single patch file attachment containing all the patches. Thanks.
Sorry Greg, I forgot to include a patch for the constants class, I'll update it shortly. Do you want me to replace the tar.gz with one big patch or just add patch that is missing?
Just the missing patch will be fine.
Created attachment 228137 [details] adds required constants This fixes missing changes from the code cleanup patch zip file.
Committed.
Thanks! By the way, I wasn't sure what to put for the version (it's 1.0.0.qualifier). So that and the pom might need to be updated to sync up with everything else.
It looks like there are a bunch of xjc generated classes in data/org/eclipse/ptp/etfw/jaxb in the org.eclipse.ptp.etfw.jaxb plugin. Should these be under src or removed?
Oops, that's my mistake. I should not have include those xjc files from data in my attached zip file. Sorry about that. Everything that is under the src folder is the latest compilation of the xsd.
Closing this as completed.
