Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 397558 - Allow the DatabasePlatform to modify the ALTER TABLE ADD <column> clause
Summary: Allow the DatabasePlatform to modify the ALTER TABLE ADD <column> clause
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Eclipselink (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Nobody - feel free to take it CLA
QA Contact:
URL:
Whiteboard: submitted_patch
Keywords:
Depends on:
Blocks: 397559
  Show dependency tree
 
Reported: 2013-01-07 06:47 EST by Sabine Heider CLA
Modified: 2022-06-09 10:36 EDT (History)
2 users (show)

See Also:

Attachments
Patch that allows to overwrite the ALTER TABLE ADD column statement (2.98 KB, patch)
2013-01-07 06:52 EST, Sabine Heider CLA 		tom.ware: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sabine Heider CLA 2013-01-07 06:47:21 EST 
The syntax for the ALTER TABLE ADD <column> statement may be different on different database platforms. There should be a mechanism for a database platform to adapt the generated statement for their particular needs.
(Background: SAP HANA database requires a slightly different syntax to add a column to a table).

I'll add a patch that adds a "writeAddColumnClause" to the DatabasePlatform class that allows to modify the string following the ALTER TABLE. Please review and let me know if that's okay or if you'd prefer a different approach.
Comment 1 Sabine Heider CLA 2013-01-07 06:52:20 EST 
Created attachment 225272 [details]
Patch that allows to overwrite the ALTER TABLE ADD column statement
Comment 2 Sabine Heider CLA 2013-01-08 07:08:27 EST 
I made a github contribution for that change and created a pull request:
https://github.com/sabineheider/eclipselink.runtime/commit/af3f0148ec09546adc67f904ddd31eb00cd46eb8
Comment 3 Tom Ware CLA 2013-01-10 15:16:48 EST 
Checked in changes.

reviewed by: Tom Ware - reviewed submitted changes

Tested with Core and JPA LRG
Comment 4 Eclipse Webmaster CLA 2022-06-09 10:36:03 EDT 
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink