Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 396906 - Provide support for packages in new wizards (with patch)
Summary: Provide support for packages in new wizards (with patch)
Status: RESOLVED FIXED
Alias: None
Product: DLTK
Classification: Technology
Component: Common (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: dltk.common-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-19 05:44 EST by Jens Von Pilgrim CLA
Modified: 2012-12-21 02:07 EST (History)
1 user (show)

See Also:


Attachments
Patch with code contribution for bundle org.eclipse.dltk.core (29.16 KB, patch)
2012-12-19 05:44 EST, Jens Von Pilgrim CLA
alex.panchenko: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jens Von Pilgrim CLA 2012-12-19 05:44:37 EST
Created attachment 224910 [details]
Patch with code contribution for bundle org.eclipse.dltk.core

In o.e.dltk.core, the NewSourceModulePage and its super class NewContainerWizardPage provide support for a file name (of the new source module) and its container, that is the source folder. Many languages use the concept of packages (which are represented as folders). At the moment it is not possible to select a source folder _and_ a package separately. 

Please find attached a patch providing a new page class NewSourceModuleInPackagePage, extending NewSourceModulePage and adding the concept of packages. Optionally, the new page can be configured in order to create missing packages (i.e., folders) automatically. I tried to change as few things in the existing code as possible. Also, I tried to implement the Liskov substitution principle, that is the subclass can be used similar to its super class.

As the code contribution exceeds the limit of 250 lines, I expect a CQ to be created. There for I confirm that
(a) I wrote 100% of the code;  
(b) I have the right to contribute the code to Eclipse;  and 
(c) the file header contains the appropriate License header.

Regards,
Jens

PS: I created the patch using diff against the latest master version (12/19/2012).
Comment 1 Alex Panchenko CLA 2012-12-21 01:48:06 EST
CQ 6958 was approved
Comment 2 Alex Panchenko CLA 2012-12-21 02:07:37 EST
Applied the patch.