Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 396882 - updated blue waters contributed Torque-ALPS resource manager/target configuration
Summary: updated blue waters contributed Torque-ALPS resource manager/target configura...
Status: CLOSED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: RM.PBS (show other bugs)
Version: 6.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 7.0   Edit
Assignee: Jeffrey Overbey CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-18 17:56 EST by Jay Alameda CLA
Modified: 2013-03-11 21:16 EDT (History)
3 users (show)

See Also:


Attachments
contributed blue waters target configuration (25.14 KB, text/xml)
2012-12-18 17:56 EST, Jay Alameda CLA
no flags Details
updated file with additional comment for this change (25.22 KB, text/xml)
2013-01-04 10:06 EST, Galen Arnold CLA
g.watson: iplog+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jay Alameda CLA 2012-12-18 17:56:52 EST
Created attachment 224901 [details]
contributed blue waters target configuration

Galen Arnold updated the contributed blue waters torque-Alps target configuration, which is attached - we would like to see this in the next releases of PTP -
This replaces both of the previous target configurations/resource managers
Comment 1 Jeffrey Overbey CLA 2012-12-26 15:59:52 EST
Jay, I'm running into some problems with Eclipse that may take a couple of days to sort out, so I'm going to reset the assignee for this bug.  If Greg or someone wants to commit this in the mean time, that would be great.

Also, to satisfy the IP folks, please ask Galen to add a comment to this bug confirming that:

(a) he wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others,
(b) he has the right to contribute the code to Eclipse, and
(c) he has included the EPL license header in all source files.

Thanks!
Comment 2 Jay Alameda CLA 2013-01-03 11:37:12 EST
Thank you, Jeff. 
I will chase this down.
I suspect that his resource manager is a modification of what you wrote originally, if so, how should we handle this?
Thanks -
Jay
Comment 3 Jay Alameda CLA 2013-01-03 12:07:34 EST
Jeff,

The situation is not pretty (from Galen:
"That xml config is a modification of Jeff's, which was a modification of mine, which was a modification of Al's original."
I suspect too that Greg may have done a mass-edit when the schema drifted/changed back when we did away with resource managers... 

I wonder if some git cleverness would help us manage this?  Though that all would be defeated, I think, by the ability for anyone to pull the xml out of the plugin.  Hmmmm... not sure how to sort this out in a clean way.

Jay
Comment 4 Jeffrey Overbey CLA 2013-01-03 14:41:20 EST
Hi Jay,

> The situation is not pretty (from Galen:
> "That xml config is a modification of Jeff's, which was a modification of
> mine, which was a modification of Al's original."

No problem; Galen can just state that, noting that the modifications to the original BW target config are 100% his own.

This is just standard boilerplate for IP provenance.  The IP team wants assurance the EPL code hasn't been contaminated with code under another license, and that there aren't any "hidden" authors who could later claim ownership or invalidate the license.

Since Galen's code is a modification of other PTP code, as long as he did all the modifications himself, there's no problem.

Sorry for the confusion.
Comment 5 Galen Arnold CLA 2013-01-04 10:06:35 EST
Created attachment 225219 [details]
updated file with additional comment for this change

<!-- * Galen Arnold - adapt to Blue Waters round 2: free form aprun box -->

...added to the end of the comments for this file.
Comment 6 Galen Arnold CLA 2013-01-04 10:08:11 EST
The comments for the file are shown below and correct to the best of my knowledge.

<!-- ******************************************************************************* -->
<!-- * Copyright (c) 2011-2012 University of Illinois.  All rights reserved. -->
<!-- * This program and the accompanying materials are made available under the -->
<!-- * terms of the Eclipse Public License v1.0 which accompanies this distribution, -->
<!-- * and is available at http://www.eclipse.org/legal/epl-v10.html -->
<!-- * -->
<!-- * Contributors: -->
<!-- * Al Rossi - initial design and implementation (PBS) -->
<!-- * Galen Arnold - adapt to mvapich2 -->
<!-- * Jeff Overbey - adapt to Blue Waters -->
<!-- * Galen Arnold - adapt to Blue Waters round 2: free form aprun box -->
<!-- ****************************************************************************** -->
Comment 7 Jeffrey Overbey CLA 2013-03-11 21:16:52 EDT
Committed to master for Kepler with two changes:

Line 15 changed to:
xmlns="http://eclipse.org/ptp/schemas"

Line 635 changed to:
<widget type="custom" typeId="envconfig" style="SWT.NONE" attribute="modules">

Galen, please let me know if you need any further changes.  Sorry this took so long.