Community
Participate
Working Groups
The Ctrl-C accelerator and main menu's Edit->Copy action doesn't work in Variables, Breakpoints, and Registers view. The context menu's Copy Variables action still works as expected.
This bug seems specific to CDT, it works fine with JDT.
Created attachment 224683 [details] Patch with fix. It looks like I introduced this bug with the fix to bug 344023. There is logic in the variables view which saves and restores the copy/paste actions when switching focus between tree viewer and detail pane. In the refactoring I removed the step which saved the copy and paste actions that were originally set to the view. This fix covers most of the cases, but I found one instance where it fails. If the previous detail pane in the view is disposed, the DefaultDetailPane dispose listener clears the actions from the action bars, whether the pane had focus or not. I think we need to do something more sophisticated in the default detail pane, but it could get messy.
Created attachment 224697 [details] Updated patch. When testing I found that my simple fix would overwrite the paste actions from expressions and breakpoints views. I developed this more comprehensive patch which works, but I had to change how the expressions and breakpoints views use the action DIs when calling AbstractDebugView.setAction().
Mike, could you review my patch. I'm not 100% that I'm using the action IDs as they were intended. Also, I know you'd like to replace this whole scheme with command contributions.
-1. The patch breaks copy and select all in the breakpoint condition editor (in the detail pane). Steps: 1. create line breakpoint 2. enter the condition "return true;" 3. hit Ctrl+A -> looks like it does a save and changes the state of the detail pane 4. redo steps 1 and 2, manually select all 5. Ctrl + C, then delete the condition 6. Ctrl+V -> nothing happens
(In reply to comment #5) > -1. The patch breaks copy and select all in the breakpoint condition editor > (in the detail pane). > > Steps: > 1. create line breakpoint > 2. enter the condition "return true;" > 3. hit Ctrl+A -> looks like it does a save and changes the state of the > detail pane Its actually doing a select all in the breakpoints viewer above.
Created attachment 224827 [details] Updated (again). I made a small adjusted and did more extensive testing. Mike, please have a look again.
I pushed the fix to master. I'd like to get this into 4.2.2 as well, but will create a separate bug for that.
Fix commit: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=fded632c531a923715e02bb661c3033a7b221dbb
+1 works fine
Verified in I20130122-0800.
