Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 396278 - Removal of Best Practices section in Jubula documentation
Summary: Removal of Best Practices section in Jubula documentation
Status: CLOSED FIXED
Alias: None
Product: Jubula
Classification: Technology
Component: UA (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Jan Philipp Wiegmann CLA
QA Contact: Alexandra Schladebeck CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-11 09:44 EST by Jan Philipp Wiegmann CLA
Modified: 2013-02-07 02:09 EST (History)
2 users (show)

See Also:

Attachments
Patch removing best practices section from documentation (18.84 KB, patch)
2012-12-11 09:44 EST, Jan Philipp Wiegmann CLA 		no flags Details | Diff
Updated patch with removed references and files/directories (55.99 KB, patch)
2013-01-25 07:20 EST, Jan Philipp Wiegmann CLA 		no flags Details | Diff
Updated patch created via git format-patch (413.45 KB, patch)
2013-02-04 09:56 EST, Jan Philipp Wiegmann CLA 		alexandra.schladebeck: iplog+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Philipp Wiegmann CLA 2012-12-11 09:44:01 EST 
Created attachment 224562 [details]
Patch removing best practices section from documentation

I removed the Best Practices section and all pointers on this section. If it was necessary i also removed the context.
Comment 1 Alexandra Schladebeck CLA 2012-12-14 07:31:28 EST 
Rejecting this patch on the basis that the files for the best practice section have not been removed, just all references to them. Please remove the actual files and directories as well.
Comment 2 Jan Philipp Wiegmann CLA 2013-01-25 07:20:16 EST 
Created attachment 226090 [details]
Updated patch with removed references and files/directories
Comment 3 Achim Loerke CLA 2013-01-30 02:47:49 EST 
@Triage:+

Bookkeeping
Comment 4 Achim Loerke CLA 2013-01-30 02:50:17 EST 
@Triaged:+

Fixed typo
Comment 5 Alexandra Schladebeck CLA 2013-02-04 09:26:22 EST 
Jan, I can't apply the patch because the binary files are not correct. Can you recreate the patch so that the files are correct?
Comment 6 Jan Philipp Wiegmann CLA 2013-02-04 09:56:10 EST 
Created attachment 226509 [details]
Updated patch created via git format-patch

Hopefully this patch will work.
Comment 7 Alexandra Schladebeck CLA 2013-02-04 10:41:05 EST 
Thanks Jan! 

Patch applied with:
http://git.eclipse.org/c/jubula/org.eclipse.jubula.core.git/commit/?id=139ca2dcc03fd0db0a6d703e5b7da79ae5a70abb
Comment 8 Oliver Goetz CLA 2013-02-06 08:02:15 EST 
Tested. Best practices section has been removed from documentation/user manual
Comment 9 Jan Philipp Wiegmann CLA 2013-02-06 08:27:53 EST 
Closing this due to comment 8.