Comment 1 Szymon Ptaszkiewicz 2012-12-10 08:53:25 EST

Moving to JDT/Core for comment.

Comment 2 Jay Arthanareeswaran 2012-12-10 09:03:15 EST

Stephan, I don't have access to post b64 JDK versions. Do you see this with b65 or later?

Comment 3 Jay Arthanareeswaran 2012-12-11 00:46:47 EST

(In reply to comment #2)
> Stephan, I don't have access to post b64 JDK versions. Do you see this with
> b65 or later?

Actually, never mind. I can reproduce it with HEAD and b65 JDK.

Comment 4 Jay Arthanareeswaran 2012-12-11 01:49:56 EST

Created attachment 224549 [details]
Proposed fix

This should do.

Olivier, do you think anything else is required for the batch compiler?

Comment 5 Olivier Thomann 2012-12-11 12:01:10 EST

(In reply to comment #4)
> Created attachment 224549 [details] [diff]
> Proposed fix
> 
> This should do.
> 
> Olivier, do you think anything else is required for the batch compiler?
No, I think this should be good enough. In the code you modify, I would actually replace the 52, 51, 50, ... with the constants from ClassFileConstants.
Something like this:

private boolean checkVMVersion(long minimalSupportedVersion) {
	// the format of this property is supposed to be xx.x where x are digits.
	String classFileVersion = System.getProperty("java.class.version"); //$NON-NLS-1$
	if (classFileVersion == null) {
		// by default we don't support a class file version we cannot recognize
		return false;
	}
	int index = classFileVersion.indexOf('.');
	if (index == -1) {
		// by default we don't support a class file version we cannot recognize
		return false;
	}
	int majorVersion;
	try {
		majorVersion = Integer.parseInt(classFileVersion.substring(0, index));
	} catch (NumberFormatException e) {
		// by default we don't support a class file version we cannot recognize
		return false;
	}
	switch(majorVersion) {
		case ClassFileConstants.MAJOR_VERSION_1_1 : // 1.0 and 1.1
			return ClassFileConstants.JDK1_1 >= minimalSupportedVersion;
		case ClassFileConstants.MAJOR_VERSION_1_2 : // 1.2
			return ClassFileConstants.JDK1_2 >= minimalSupportedVersion;
		case ClassFileConstants.MAJOR_VERSION_1_3 : // 1.3
			return ClassFileConstants.JDK1_3 >= minimalSupportedVersion;
		case ClassFileConstants.MAJOR_VERSION_1_4 : // 1.4
			return ClassFileConstants.JDK1_4 >= minimalSupportedVersion;
		case ClassFileConstants.MAJOR_VERSION_1_5 : // 1.5
			return ClassFileConstants.JDK1_5 >= minimalSupportedVersion;
		case ClassFileConstants.MAJOR_VERSION_1_6 : // 1.6
			return ClassFileConstants.JDK1_6 >= minimalSupportedVersion;
		case ClassFileConstants.MAJOR_VERSION_1_7 : // 1.7
			return ClassFileConstants.JDK1_7 >= minimalSupportedVersion;
		case ClassFileConstants.MAJOR_VERSION_1_8 :
			return ClassFileConstants.JDK1_8 >= minimalSupportedVersion;
	}
	// unknown version
	return false;
}

Comment 6 Jay Arthanareeswaran 2012-12-11 23:49:45 EST

Created attachment 224610 [details]
Patch to use constants instead of literals

All tests pass. Will wait till M4 is out before releasing.

Comment 7 Jay Arthanareeswaran 2013-01-01 00:30:19 EST

Released the fix via commit:

http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=5a4b4a5bb82958c7c1b641811ee8d4c999d39c4e

Comment 8 Manoj N Palat 2013-03-12 04:44:30 EDT

Verified for 4.3 M6 build id: I20130310-2000