Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 395144 - [patch] The install artifact wizard does not process POM in different location
Summary: [patch] The install artifact wizard does not process POM in different location
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: m2e (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-27 05:36 EST by Marcos Munoz CLA
Modified: 2021-04-19 13:23 EDT (History)
3 users (show)

See Also:
jmmunoz: review? (igor)


Attachments
Patch submitted (3.25 KB, application/octet-stream)
2012-11-28 16:29 EST, Marcos Munoz CLA
igor: iplog+
jmmunoz: review?
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marcos Munoz CLA 2012-11-27 05:36:08 EST
When you launch the "Install or deploy artifact to a Maven repository" wizard. 

The user can select the location of the artifact and the POM. If both files are at the same location (folder) the code validates if the artifact already exists in the repository and extracts the information from the POM (group id, artifact id, and so on). 

The issue here is that if the POM is in another location, the data extraction from the POM is not being done. 

The data extraction code should be refactored in a different method so it could be called during the artifact location set up as in the POM location set up.

Besides this issue, I'm curious about the use of the "Generate POM" option. 

If the option is checked, will the wizard generate a new POM even if the user have provided one?

If the answer is No, the option should be disabled when the user enters the location of a valid POM to avoid confusion about the wizard operation.
Comment 1 Igor Fedorenko CLA 2012-11-27 05:45:26 EST
I know I sound like a broken record, but m2e dev team most likely will not be able to look at these issues unless a quality patch is provided.
Comment 2 Marcos Munoz CLA 2012-11-27 06:14:43 EST
Igor, I understand that the workload might not let you handle low priority bugs. But by start this can help us to track that the issue exists. And I'm willing to provide a patch for this under the m2e team supervision if that is ok for you
Comment 3 Igor Fedorenko CLA 2012-11-27 07:14:08 EST
Yes, absolutely, please attach a patch here and I'll try my best to review it in timely fashion. If you have specific questions about m2e development environment or source code structure, m2e-dev is the place to ask.
Comment 4 Marcos Munoz CLA 2012-11-28 16:29:57 EST
Created attachment 224082 [details]
Patch submitted

The patch moved the code to read the POM file data into a method. This method is used when the artifact name is entered and when the pom file name is entered.
Comment 5 Marcos Munoz CLA 2012-11-28 16:31:37 EST
Patch submitted, requesting review
Comment 6 Igor Fedorenko CLA 2012-12-16 13:12:06 EST
Applied the patch. Thank you.


http://git.eclipse.org/c/m2e/m2e-core.git/commit/?id=bd1d499d0eaa3cd57e0cfddd1544d49f1eff76dd
Comment 7 Denis Roy CLA 2021-04-19 13:23:35 EDT
Moved to https://github.com/eclipse-m2e/m2e-core/issues/