Community
Participate
Working Groups
Generally the outliner is helpful, but there are two places to improve: * when the file is big it is hard to find the function/object on the list, because the list tends to get long * to jump somewhere using outliner user needs to let go the keyboard and use the mouse, this is usually while his typing It would be great if we had outliner filter where user could type the part of the name he wants to jump to. Even better if this filter could be focused using some keyboard shortcut and could help to select outliner items only using the keyboard (like a filtered dropdown). Then I could jump to a function I need very fast: using few keystrokes only.
See also bug 374400 which talks about a popup outliner like Ctrl+O in Eclipse. To me this is the most keyboard friendly way to jump to a particular method.
We talked about this today in node meeting, I would like to take it and consider to make part of the search completion generic. Also see Mark's comment on bug 359480 comment 6.
The Scripted editor has a pop-up outline view with filter. Andrew is this anything that could easily be pulled back in or is it dependent on framework/artifacts not in the Orion code?
I just stumbled upon this bug. As was mentioned in yesterday's status meeting I'm currently working on adding exactly this functionality to the outliner. I have most of the code already. Unfortunately, I can't seem to modify the "Assigned To" field in bugzilla so could someone with that capability please assign this bug to me? I will be posting a proposed fix shortly.
Here's the proposed fix: https://github.com/elijahe/orion.client/commit/039314b7b72d3d8a0d044395b198e3f08e6037b6 Please review and commit if appropriate. Also, please note that in order for this to work properly the fixes in the dependent bugs, especially 389633, need to be committed first. Finally, I'd like to add support for traversing the filtered items in the outline using key up and key down. However, I think it's best to keep that as a separate commit.
Here's an additional patch which improves the filtering in the previous commit: https://github.com/elijahe/orion.client/commit/361088d2941e8ed98cdc3bc5297805c354470317 Please also review this and commit it together with the change in the previous link if appropriate.
Here are the latest 3 commits after Silenio's code review (include previous two commits and modifications suggested during code review): https://github.com/elijahe/orion.client/commit/97ef127a375d1773f40dd07633ba5bd1bdad13f5 https://github.com/elijahe/orion.client/commit/7c978141680cc27c61cfe078ed4edeb2112f9c6b https://github.com/elijahe/orion.client/commit/976f2393ebe5a94142bb363840b68c54d5ac921d
The following commit contains these improvements: - Added up/down key outline navigation support when filter has focus and when table rows are hidden. - Added support for pressing Enter on an outline item. - Made the filter input box position fixed. https://github.com/elijahe/orion.client/commit/b64ccd15070b223ce9f5a4067e177db00c5d49c9 This next commit contains even more improvements to the outline filter. It moves the filter input into the sidebar toolbar area where it fits nicely. It also adds primitive regexp support in the filter (* = any string, ? = any character) similar to the regexp support in the file search dialog. https://github.com/elijahe/orion.client/commit/a424824c1192d79e60d59f598e2ca481fd37c58c
(In reply to Elijah El-Haddad from comment #7) > Here are the latest 3 commits after Silenio's code review (include previous > two commits and modifications suggested during code review): > https://github.com/elijahe/orion.client/commit/ > 97ef127a375d1773f40dd07633ba5bd1bdad13f5 > https://github.com/elijahe/orion.client/commit/ > 7c978141680cc27c61cfe078ed4edeb2112f9c6b > https://github.com/elijahe/orion.client/commit/ > 976f2393ebe5a94142bb363840b68c54d5ac921d These have been pushed to eclipse.org. I will review the other two next.
Latest commit after review by Silenio: https://github.com/elijahe/orion.client/commit/853b5cbfa95755cd48853c2f7a4b46b8aad542e7
Pushed comment#8 and comment#10 to eclipse.org.
Minor fix to prevent the outline view from being scrolled down when the DOWN key is used to jump from the Filter input into the outline: https://github.com/elijahe/orion.client/commit/6b697074355c602b8332234fe4ed9c1e068eae75
(In reply to Elijah El-Haddad from comment #12) > Minor fix to prevent the outline view from being scrolled down when the DOWN > key is used to jump from the Filter input into the outline: > > https://github.com/elijahe/orion.client/commit/ > 6b697074355c602b8332234fe4ed9c1e068eae75 Looks good. Pushed to eclipse.org. Thanks.
Thank you Silenio for reviewing the changes and pushing them. This bug is fixed.
