Community
Participate
Working Groups
The parent of the platform build is org.eclipse:eclipse-parent:1.0.0-SNAPSHOT However it seems that this is GA is already being used for another purpose and worst a completely unrelated version of org.eclipse:eclipse-parent:1.0.0-SNAPSHOT is already available: http://maven.eclipse.org/nexus/service/local/repositories/nightly-indigo/content/org/eclipse/eclipse-parent/1.0.0.0-SNAPSHOT/eclipse-parent-1.0.0.0-20110530.151255-2.pom A better GA for platform parent could be org.eclipse:eclipse-platform-parent
Seems reasonable to me, though I don't know much about maven conventions. Paul, Thanh, any objections?
(In reply to comment #1) > Seems reasonable to me, though I don't know much about maven conventions. > > Paul, Thanh, any objections? I think this change is reasonable. There is however a few places that will need to be modified if this change is to occur. Both artifactId as well as relativePath configuration will need to be modified in all the files below: % find . -name pom.xml | xargs grep eclipse-parent ./eclipse.pde.ui/pom.xml: <artifactId>eclipse-parent</artifactId> ./eclipse.pde.ui/pom.xml: <relativePath>../eclipse-parent</relativePath> ./eclipse.platform.releng.tychoeclipsebuilder/pom.xml: <artifactId>eclipse-parent</artifactId> ./eclipse.platform.releng.tychoeclipsebuilder/pom.xml: <relativePath>../eclipse-parent</relativePath> ./eclipse.platform.releng.tychoeclipsebuilder/eclipse-junit-tests/pom.xml: <artifactId>eclipse-parent</artifactId> ./eclipse.platform.releng.tychoeclipsebuilder/eclipse-junit-tests/pom.xml: <relativePath>../eclipse-parent</relativePath> ./eclipse.platform.swt.binaries/pom.xml: <artifactId>eclipse-parent</artifactId> ./eclipse.platform.swt.binaries/pom.xml: <relativePath>../eclipse-parent</relativePath> ./rt.equinox.bundles/pom.xml: <artifactId>eclipse-parent</artifactId> ./rt.equinox.bundles/pom.xml: <relativePath>../eclipse-parent</relativePath> ./eclipse.jdt.core.binaries/pom.xml: <artifactId>eclipse-parent</artifactId> ./eclipse.jdt.core.binaries/pom.xml: <relativePath>../eclipse-parent</relativePath> ./eclipse.platform.debug/pom.xml: <artifactId>eclipse-parent</artifactId> ./eclipse.platform.debug/pom.xml: <relativePath>../eclipse-parent</relativePath> ./eclipse.jdt.debug/pom.xml: <artifactId>eclipse-parent</artifactId> ./eclipse.jdt.debug/pom.xml: <relativePath>../eclipse-parent</relativePath> ./eclipse.jdt/pom.xml: <artifactId>eclipse-parent</artifactId> ./eclipse.jdt/pom.xml: <relativePath>../eclipse-parent</relativePath> ./eclipse.platform.repository/pom.xml: <artifactId>eclipse-parent</artifactId> ./eclipse.platform.repository/pom.xml: <relativePath>../eclipse-parent</relativePath> ./eclipse.platform.ui/pom.xml: <artifactId>eclipse-parent</artifactId> ./eclipse.platform.ui/pom.xml: <relativePath>../eclipse-parent</relativePath> ./eclipse.platform.text/pom.xml: <artifactId>eclipse-parent</artifactId> ./eclipse.platform.text/pom.xml: <relativePath>../eclipse-parent</relativePath> ./pom.xml: <module>eclipse-parent</module> ./eclipse.platform.common/pom.xml: <artifactId>eclipse-parent</artifactId> ./eclipse.platform.common/pom.xml: <relativePath>../eclipse-parent</relativePath> ./eclipse.pde/pom.xml: <artifactId>eclipse-parent</artifactId> ./eclipse.pde/pom.xml: <relativePath>../eclipse-parent</relativePath> ./eclipse.jdt.ui/pom.xml: <artifactId>eclipse-parent</artifactId> ./eclipse.jdt.ui/pom.xml: <relativePath>../eclipse-parent</relativePath> ./eclipse-parent/pom.xml: <artifactId>eclipse-parent</artifactId> ./eclipse.platform.releng/pom.xml: <artifactId>eclipse-parent</artifactId> ./eclipse.platform.releng/pom.xml: <relativePath>../eclipse-parent</relativePath> ./eclipse.pde.build/pom.xml: <artifactId>eclipse-parent</artifactId> ./eclipse.pde.build/pom.xml: <relativePath>../eclipse-parent</relativePath> ./eclipse.platform.resources/pom.xml: <artifactId>eclipse-parent</artifactId> ./eclipse.platform.resources/pom.xml: <relativePath>../eclipse-parent</relativePath> ./rt.equinox.framework/pom.xml: <artifactId>eclipse-parent</artifactId> ./rt.equinox.framework/pom.xml: <relativePath>../eclipse-parent</relativePath> ./eclipse.platform.runtime/pom.xml: <artifactId>eclipse-parent</artifactId> ./eclipse.platform.runtime/pom.xml: <relativePath>../eclipse-parent</relativePath> ./eclipse.platform/pom.xml: <artifactId>eclipse-parent</artifactId> ./eclipse.platform/pom.xml: <relativePath>../eclipse-parent</relativePath> ./eclipse.platform.swt/pom.xml: <artifactId>eclipse-parent</artifactId> ./eclipse.platform.swt/pom.xml: <relativePath>../eclipse-parent</relativePath> ./rt.equinox.p2/pom.xml: <artifactId>eclipse-parent</artifactId> ./rt.equinox.p2/pom.xml: <relativePath>../eclipse-parent</relativePath> ./rt.equinox.p2/org.eclipse.equinox.p2.releng/org.eclipse.equinox.p2-parent/pom.xml: <artifactId>eclipse-parent</artifactId> ./eclipse.jdt.core/pom.xml: <artifactId>eclipse-parent</artifactId> ./eclipse.jdt.core/pom.xml: <relativePath>../eclipse-parent</relativePath> ./eclipse.platform.team/pom.xml: <artifactId>eclipse-parent</artifactId> ./eclipse.platform.team/pom.xml: <relativePath>../eclipse-parent</relativePath> ./eclipse.platform.ua/pom.xml: <artifactId>eclipse-parent</artifactId> ./eclipse.platform.ua/pom.xml: <relativePath>../eclipse-parent</relativePath>
We also have Bug 397850 which will effect most of the pom files. When talking to John, we are likely to backport changes to 4.2.2 after SR2, is that correct? So this is targetting Kepler? If so, we should rename both the eclipse-parent and the bundle groupIds at the same time. For the parent, we can use a groupId of org.eclipse.releng to differentiate it from the org.eclipse:eclipse-parent. PW
Targeting 422+ just because bug 397850 does. They should "go together". Actually, I personally do not know if these are important for 422+? They would be if important for LTS, but if not important for LTS, then not?
(In reply to comment #4) > Targeting 422+ just because bug 397850 does. They should "go together". > > Actually, I personally do not know if these are important for 422+? Right, we need to fix the naming for LTS as well as Kepler, so I hoped to do the fix in both master and 4.2.2+ PW
We are going to have a coordinated change on Monday, 2/25. So, to be explicit, a committer from a project would be able to checkout their repo as a general project (general project, so they make changes needed in "root" pom) and do 2 global replaces, in pom.xml files only, of 1: find/replace <artifactId>eclipse-parent</artifactId> with <artifactId>org.eclipse:eclipse-platform-parent</artifactId> and 2: find/replace <relativePath>../eclipse-parent</relativePath> with <relativePath>../eclipse-platform-parent</relativePath> (that is, name space of "org.eclipse:" does not go in relative path, right?)
(In reply to comment #6) > > 1: > find/replace > <artifactId>eclipse-parent</artifactId> > with > <artifactId>org.eclipse:eclipse-platform-parent</artifactId> > > (that is, name space of "org.eclipse:" does not go in relative path, right?) I don't believe that org.eclipse: goes into this artifactId, since it is specified in the groupId in the parent section of the pom PW
(In reply to comment #7) > (In reply to comment #6) > > > > 1: > > find/replace > > <artifactId>eclipse-parent</artifactId> > > with > > <artifactId>org.eclipse:eclipse-platform-parent</artifactId> > > > > (that is, name space of "org.eclipse:" does not go in relative path, right?) > > I don't believe that org.eclipse: goes into this artifactId, since it is > specified in the groupId in the parent section of the pom > > PW Excellent, I was just getting ready to ask that. That makes this change easier. But more questions for bug 397850 :)
So, to net this out, again, we are going to have a coordinated change on Monday, 2/25. To cover all time zones, lets say you can start any time after Sunday night's build completes ... say, Midnight (Eastern time). I'd also like to set to to-be-completed time of 3 PM Monday (Eastern) which gives some time for me to do a local test build, and if anyone missed one or two, time to send a nag note before the 8 PM build. In each pom.xml of your repository, including the "root" one, and tests, and features. 1: find/replace <artifactId>eclipse-parent</artifactId> with <artifactId>eclipse-platform-parent</artifactId> and 2: find/replace <relativePath>../eclipse-parent</relativePath> with <relativePath>../eclipse-platform-parent</relativePath> Commit and push. Master is the highest priority, but we also want this change in the R3_8_maintenance and R4_2_maintenance branch (for LTS, known as 422+ target in bugzilla), so just as well make in all branches, on Monday. Cherry picking should normally work without conflicts (AFAIK) so hopefully won't be too much effort to do all branches. (Other than maybe those few cases where there are different projects/repos between 38 and 42).
Does the group id changes?
(In reply to comment #10) > Does the group id changes? That's not part of the plan now. Should it be? PW
(In reply to comment #11) > (In reply to comment #10) > > Does the group id changes? > > That's not part of the plan now. Should it be? I did not imply that it should be changed :) Just wanted to be sure that if it was needed, then we should do now. I've just looked at it and it is seems good to me as org.eclipse Though I've opened a discussion to decide on how to structure groupIds as an organization in bug #401450.
I've renamed the parent itself. http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=d755875b68df526956778c1eb1ae5de4f44c5b5f Thanh or Paul, please double check. (As far as I can tell at the moment, nothing in "the aggregator" needs a groupId change ... none of them are "artifacts" in the same sense as bundles/features. I'll make similar comment in sister bug, and you can correct me if I'm wrong.)
(In reply to comment #9) > In each pom.xml of your repository, including the "root" one, and tests, and > features. > > 1: > find/replace > <artifactId>eclipse-parent</artifactId> > with > <artifactId>eclipse-platform-parent</artifactId> None of the pom files in JDT/Core repo other than the 'root' refers to eclipse-parent. This is what the pom files contain: <parent> <artifactId>eclipse.jdt.core</artifactId> <groupId>eclipse.jdt.core</groupId> <version>3.8.0-SNAPSHOT</version> </parent> I see jdt.ui projects also have similar values. Should the artifactId be added in these cases?
(In reply to comment #14) > (In reply to comment #9) > > In each pom.xml of your repository, including the "root" one, and tests, and > > features. > > > > 1: > > find/replace > > <artifactId>eclipse-parent</artifactId> > > with > > <artifactId>eclipse-platform-parent</artifactId> > > None of the pom files in JDT/Core repo other than the 'root' refers to > eclipse-parent. This is what the pom files contain: Then just the root pom needs the value replaced. The others are fine (or fall under Bug 397850 ) PW
> ./eclipse.platform.resources/pom.xml: <artifactId>eclipse-parent</artifactId> > ./eclipse.platform.resources/pom.xml: <relativePath>../eclipse-parent</relativePath> Done for master at eclipse.platform.resources.
Fixed in 'master' for: eclipse.jdt eclipse.jdt.debug eclipse.jdt.ui eclipse.pde eclipse.pde.build eclipse.pde.ui eclipse.platform eclipse.platform.common eclipse.platform.debug eclipse.platform.releng eclipse.platform.runtime eclipse.platform.team eclipse.platform.text eclipse.platform.ua eclipse.platform.ui
Released in master and R3_8_maintenance for the following repos: eclipse.jdt.core eclipse.jdt.core.binaries
Fixed in 'R3_8_maintenance' for: eclipse.jdt eclipse.jdt.debug eclipse.jdt.ui eclipse.pde eclipse.pde.build eclipse.pde.ui eclipse.platform eclipse.platform.common eclipse.platform.debug eclipse.platform.releng eclipse.platform.resources eclipse.platform.team eclipse.platform.text eclipse.platform.ua eclipse.platform.ui NOTE: There was no branch for eclipse.platform.runtime
Fixed in 'R4_2_maintenance' for: eclipse.platform eclipse.platform.common eclipse.platform.releng eclipse.platform.runtime eclipse.platform.ui
(In reply to comment #13) > I've renamed the parent itself. > > http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/ > commit/?id=d755875b68df526956778c1eb1ae5de4f44c5b5f > > Thanh or Paul, please double check. > > (As far as I can tell at the moment, nothing in "the aggregator" needs a > groupId change ... none of them are "artifacts" in the same sense as > bundles/features. I'll make similar comment in sister bug, and you can > correct me if I'm wrong.) Only thing I can think of are the items in tychoeclipsebuilder, but it looks like those items don't even define a groupId so maybe they don't need it.
(In reply to comment #19) > > NOTE: There was no branch for eclipse.platform.runtime I created R3_8_maintenance off of R3_8_1 (there are other changes that need to go into 3.8.2+ as well) and applied your commmit. Thank you for your changes :-) PW
p2 changed committed in master and R3_8_maintenance: http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=3a3b531b16dcd550b5e2fdc0a2b2698b8ca5c089 http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?h=R3_8_maintenance&id=6f89bd711cdca8650a4365ee35de6dcca40a9470
Done for rt.equinox.bundles and rt.equinox.framework: master: http://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=e86effb131965fe37837433f642fe157c5a04e95 http://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=f60db4c27e788c88a6ffbf0835e7dd32ae7795b5 R3_8_maintenance: http://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?h=R3_8_maintenance&id=4679e169eec0df97e9b6a38e0c5a3fe2a72a3291 http://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?h=R3_8_maintenance&id=ba0fbbb90841b5de98713210b704f8179b01c451
Done for eclipse.platform.swt.git -> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=637879167435325110c10a199802c1122303fe08 http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?h=R4_2_maintenance&id=68358cd32a6144fd44b9adcc5d4ec5d739fffdb1 http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?h=R3_8_maintenance&id=0adc9a5bcb7aca399c16cc739c4fe3383f859d64 And eclipse.platform.swt.binaries.git -> http://git.eclipse.org/c/platform/eclipse.platform.swt.binaries.git/commit/?id=753b8689e49caaa319f83c3b8fde4a55eabb8783 http://git.eclipse.org/c/platform/eclipse.platform.swt.binaries.git/commit/?h=R4_2_maintenance&id=0176fabe0ccda34ca782d6766a88b92bee6c29ef http://git.eclipse.org/c/platform/eclipse.platform.swt.binaries.git/commit/?h=R3_8_maintenance&id=53661519e35c5dcd007ab8209bc8c11822f6741e
(In reply to comment #21) > (In reply to comment #13) > > I've renamed the parent itself. > > > > http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/ > > commit/?id=d755875b68df526956778c1eb1ae5de4f44c5b5f > > > > Thanh or Paul, please double check. > > > > (As far as I can tell at the moment, nothing in "the aggregator" needs a > > groupId change ... none of them are "artifacts" in the same sense as > > bundles/features. I'll make similar comment in sister bug, and you can > > correct me if I'm wrong.) > > Only thing I can think of are the items in tychoeclipsebuilder, but it looks > like those items don't even define a groupId so maybe they don't need it. Yeah, I'd prefer to stick with only obvious changes we know we need. Once we recover from that, we can fine tune at some point in the future. I've cherry picked the parent pom name changes to the two maintenance branches, now.
Created attachment 227565 [details] errors at approx. 4 PM As promised, I'm trying "test builds", and see the attached errors, so far. Most related to JDT. Forget to update relative path? (update too many of them? :) Plus, something about PDT and group ID? Might be xml syntax error? I've not looked at the poms in question ... thought I'd post these now, so others could look at in parallel.
(In reply to comment #27) > Created attachment 227565 [details] > errors at approx. 4 PM > > As promised, I'm trying "test builds", and see the attached errors, so far. > > Most related to JDT. Forget to update relative path? (update too many of > them? :) > > Plus, something about PDT and group ID? Might be xml syntax error? > > I've not looked at the poms in question ... thought I'd post these now, so > others could look at in parallel. The problem with the jde.core ones is the bundle poms did not update the groupId for their parent (repo root pom). So the root pom now has: org.eclipse.jdt But the poms under it have: eclipse.jdt.core
I had missed to update the relativePath to the parent pom. I updated it in both streams.
(In reply to comment #27) > Plus, something about PDT and group ID? Might be xml syntax error? > The platform.releng ones talking about groupId parse error is due to the end tag having a typo (extra d between 'group' and 'Id'): </groupdId>
(In reply to comment #30) > (In reply to comment #27) > > Plus, something about PDT and group ID? Might be xml syntax error? > > > > The platform.releng ones talking about groupId parse error is due to the end > tag having a typo (extra d between 'group' and 'Id'): > > </groupdId> I pushed this fix in: http://git.eclipse.org/c/platform/eclipse.platform.releng.git/commit/?id=0730c7c7e5ce3d3e02c1f5ec22a7605920bfe271
(In reply to comment #28) > (In reply to comment #27) > > Created attachment 227565 [details] > > errors at approx. 4 PM > > > > As promised, I'm trying "test builds", and see the attached errors, so far. > > > > Most related to JDT. Forget to update relative path? (update too many of > > them? :) > > > > Plus, something about PDT and group ID? Might be xml syntax error? > > > > I've not looked at the poms in question ... thought I'd post these now, so > > others could look at in parallel. > > The problem with the jde.core ones is the bundle poms did not update the > groupId for their parent (repo root pom). > > So the root pom now has: org.eclipse.jdt > But the poms under it have: eclipse.jdt.core Sorry I meant the opposite. root pom has: eclipse.jdt.core module poms have: org.eclipse.jdt So the root pom should be fixed to use <groupId>org.eclipse.jdt</group> for itself.
(In reply to comment #32) > So the root pom should be fixed to use <groupId>org.eclipse.jdt</group> for > itself. Typo: <groupId>org.eclipse.jdt</groupId>
(In reply to comment #29) > I had missed to update the relativePath to the parent pom. I updated it in > both streams. Is it possible to publish (and version) a parent in a repository so that one doesn't need a relative path?
(In reply to comment #33) > (In reply to comment #32) > > So the root pom should be fixed to use <groupId>org.eclipse.jdt</group> for > > itself. > > Typo: <groupId>org.eclipse.jdt</groupId> Bug 397850 tracks groupId changes.
If we've had everybody update their relative paths to ../eclipse-project-parent then we need to move agg/eclipse-parent to agg/eclipse-project-parent and fix eclipse.platform.releng.tychoeclipsebuilder/eclipse-junit-tests/pom.xml Otherwise a clean build fails saying that it can't find eclipse-project-parent and the relativePath points to the wrong location. Then p2 needs to fix its relative path in eclipse.platform.releng.aggregator/rt.equinox.p2/org.eclipse.equinox.p2.releng/org.eclipse.equinox.p2-parent/pom.xml, since it needs one more ../ PW
(In reply to comment #36) > Then p2 needs to fix its relative path in > eclipse.platform.releng.aggregator/rt.equinox.p2/org.eclipse.equinox.p2. > releng/org.eclipse.equinox.p2-parent/pom.xml, since it needs one more ../ > > PW Done: http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?h=R3_8_maintenance&id=bac7b13be568a00782b38cea9476bc1c331c5d02 http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/? id=80259c7ba0dbfc6a50d271d811331e64052af200
(In reply to comment #36) > If we've had everybody update their relative paths to > ../eclipse-project-parent then we need to move agg/eclipse-parent to > agg/eclipse-project-parent and fix > eclipse.platform.releng.tychoeclipsebuilder/eclipse-junit-tests/pom.xml > > Otherwise a clean build fails saying that it can't find > eclipse-project-parent and the relativePath points to the wrong location. > I was getting ready to rename the directory "eclipse-parent" to "eclipse-platform-parent" ... then a) noticed you wrote "project" above ... assuming a typo? And, b) the pom in eclipse-junit-tests has <relativePath>../eclipse-platform-parent</relativePath> assuming you meant that should be as it is, but with additional "../" <relativePath>../../eclipse-platform-parent</relativePath> And also, I see the 'sdk' under 'eclipse-junit-tests' also has <relativePath>../eclipse-platform-parent</relativePath> which I assume should have similar change <relativePath>../../eclipse-platform-parent</relativePath>
(In reply to comment #38) > I was getting ready to rename the directory "eclipse-parent" to > "eclipse-platform-parent" ... then a) noticed you wrote "project" above ... > assuming a typo? And, b) the pom in eclipse-junit-tests has Yes, that was a typo, I meant eclipse-platform-parent. Then apply the changes to eclipse-junit-tests and the other one you found, so that the relative path points to the correct directory.
Pushed in aggregator changes: master: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=38e9420deacce46216b936e33372b44648984c49 R4_2_maintenance: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?h=R4_2_maintenance&id=b02ce8644f06fabbf6ba7102ab0563f15fb8ed88 R3_8_maintenance: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?h=R3_8_maintenance&id=d293e4fe6b638d7a0761beb651796e9e5db9f793
(In reply to comment #39) > (In reply to comment #38) > > I was getting ready to rename the directory "eclipse-parent" to > > "eclipse-platform-parent" ... then a) noticed you wrote "project" above ... > > assuming a typo? And, b) the pom in eclipse-junit-tests has > > Yes, that was a typo, I meant eclipse-platform-parent. Then apply the > changes to eclipse-junit-tests and the other one you found, so that the > relative path points to the correct directory. The other one I found kept "changing" ... no kidding! I think maybe wrong editor was being selected as I clicked around. Anyway, on IRC, Thanh and I decided there's probably no reason for eclipse-junit-test to have relative directory either, that it can be point to its parent as <parent> <groupId>eclipse.platform.releng.tychoeclipsebuilder</groupId> <artifactId>eclipse.platform.releng.tychoeclipsebuilder</artifactId> <version>1.0.0-SNAPSHOT</version> </parent> As I think Gunnar was trying to tell us, in comment 35? In any case, seems the fewer relative paths the better ... more modular, for future.
(In reply to comment #41) > (In reply to comment #39) > > (In reply to comment #38) > In any case, seems > the fewer relative paths the better ... more modular, for future. Oh, meant to say ... unless someone knows of a reason its needed in this (or other) particular cases)?
(In reply to comment #42) > > Oh, meant to say ... unless someone knows of a reason its needed in this (or > other) particular cases)? I think the change in fine. In general, the parent is a pom with a packaging type of pom that contains common configuration that's applicable for its children. For example, we took advantage of the pom at the root of each repo to customize the SCM configuration for each repo, and all child poms inherited from that. PW
I pushed the junit-tests changes to aggregator. master: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=7ae31ebd1e4199e6121710419e7abfb72aea68d1 R4_2_maintenance: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?h=R4_2_maintenance&id=00b5fe0bd8ce99e0319b18599e6c9ec5cc720f12 R3_8_maintenance: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?h=R3_8_maintenance&id=964e8c5a27c0944daafc6f355f7e00d819975f80
Note for future ... be sure to check our scripts when major directories change names. :) http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=eed64451b9eb494c63513589451c9bb6d187827f
(In reply to comment #43) > (In reply to comment #42) > > In general, the parent is a pom with a packaging type of pom that contains > common configuration that's applicable for its children. > > For example, we took advantage of the pom at the root of each repo to > customize the SCM configuration for each repo, and all child poms inherited > from that. > Not that we should change anything more, now, but sounds like we sort of gave less than ideal advice about the the <relativePath> ... and doubt it matters much in near term practice, but, as we document "Platform Releng Practices" we'll want to be sure to capture the best approaches. For example, if we ever got to the point of building "just RCP" ... or, building it first ... then we might end up with a new submodule that itself would have submodules! :) [I think Git is capable of that?] But, again, I am NOT advocating further changes now. Much thanks to the whole team for hustling and hassling with this large "coordinated change".
I tried removing the "install eclipse platform parent" step from our automated scripts, since according to IRC chats we should no longer need to. And, in fact, a local test build seemed to work fine. So either I did the local test wrong, OR the localMavenRepo AND the gitCache both need to be removed from build machine. Or ... there are still 25 bundles without quite the right relativePath or groupId ... seems to come from a range of projects, from a quick read of the log. To see the list of 25, see the end of this log on DL page: http://download.eclipse.org/eclipse/downloads/drops4/I20130226-2000/buildlogs/mb050_pom-version-updater_output.txt I have put back the "install parent step", and will restart the build at 9 PM Eastern.
(In reply to comment #47) > > I have put back the "install parent step", and will restart the build at 9 > PM Eastern. Hmm, now it fails with a similar error, but there is one extra ... can't find the eclipse-platform-parent/pom.xml! [ERROR] The project (/opt/public/eclipse/builds/4I/master/gitCache/eclipse.platform.releng.aggregator/eclipse-platform-parent/pom.xml) has 1 error [ERROR] Non-readable POM /opt/public/eclipse/builds/4I/master/gitCache/eclipse.platform.releng.aggregator/eclipse-platform-parent/pom.xml: /opt/public/eclipse/builds/4I/master/gitCache/eclipse.platform.releng.aggregator/eclipse-platform-parent/pom.xml (No such file or directory) Unless someone sees a typo, I am going to "flush the caches" and let the build fetch everything. Looking in gitCache, I see the version there has an aggregator/pom.xml that (still) says <module>eclipse-parent</module> instead of what is in Git master, <module>eclipse-platform-parent</module> This implies something is wrong with our scripts so we try to install the parent (and update poms?) before fetching master of the aggregator?
After a "manual" clean, I do see the <module>eclipse-platform-parent</module> in the aggregator's pom. I've updated bug 400633 to add error checking to more scripts, fn-git-clean-aggregator in particular. I did notice some "fishy" things, while manually cleaning. First, when I tried to clean with owner's ID, e4Build, there were some .git/objects that said "permission denied" ... and indeed those were owned by "david_williams", probably from times I've tried a "test build" and forgot to use correct ID (and I usually cancel the job, in those cases). Second, by the time I went to my 'david_williams' Id, they were gone! Not sure what that's about, but might be some complication of NFS file system? (don't know if 'build' uses that). Or might be related to ACLs? In any case, for good measure, I added e4Build id to ACL list so it should always have rwx permission on any new files created too (in addition to the ones it creates). I suspect we really could remove "install parent" now that we have a clean working area ... but, haven't yet. First build. Then make right. :)
In case not obvious, everything was fine after the "manual clean". http://download.eclipse.org/eclipse/downloads/drops4/I20130226-2200/ I'll try again removing the "install parent" section of our scripts for Wednesday's 8 PM build.
I ran a few builds over the past week and haven't needed to run the build parent part of the build. I went ahead and removed that step from the wiki build instructions: http://wiki.eclipse.org/Platform-releng/Platform_Build#Running_the_build
3.8 patch released.
