Community
Participate
Working Groups
When testing with a TextView that has the 'readonly' == true option set, I found that certain text editing commands still modify the buffer. 1. Create an Editor or TextView that has the 'readonly' option enabled. For example change the embeddedEditor.html example like this (lines 34-40): > var textViewFactory = function() { > return new mTextView.TextView({ > parent: editorDomNode, > tabSize: 4, > readonly: true // read-only mode > }); > }; 2. Open the editor. Basic editing features are disabled (as expected). 3. Press Ctrl+D to delete a line. This actually succeeds and modifies the buffer. (not expected) IIRC the problematic commands are contributed by editorFeatures.js.
Simple testcase. Open editor page (edit.html) and replace "edit.html" with "readonly.html" in the URL.
Fixed http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=4246241ef023fcbfbca85c3a19aa06706f8441f9