This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 393703 - NotHandledException selecting inactive command under 'Previous Choices' in Quick access
Summary: NotHandledException selecting inactive command under 'Previous Choices' in Qu...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 4.4 M1   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-06 13:13 EST by Karen Butzke CLA
Modified: 2014-04-07 04:19 EDT (History)
4 users (show)

See Also:


Attachments
NotHandledException stack trace (2.81 KB, text/plain)
2012-11-06 13:13 EST, Karen Butzke CLA
no flags Details
Patch (12.11 KB, patch)
2013-06-18 13:56 EDT, Nobody - feel free to take it CLA
no flags Details | Diff
Updated patch (11.60 KB, text/plain)
2013-06-29 11:53 EDT, Nobody - feel free to take it CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Karen Butzke CLA 2012-11-06 13:13:33 EST
Created attachment 223263 [details]
NotHandledException stack trace

I used the quick access to run a particular command. After running it the command appears as an option in the quick access under 'Previous Choices'. The handler is no longer active (plug-in.xml 'activeWhen' now calculates as false) and either shouldn't appear in the Quick Access or should be disabled. Clicking on the command again results in the attached NotHandledException.
Comment 1 Nobody - feel free to take it CLA 2013-06-18 13:56:12 EDT
Created attachment 232513 [details]
Patch

This fix enables a previous pick only if the original provider of the pick is also providing the element.
Comment 2 Paul Webster CLA 2013-06-25 09:47:02 EDT
(In reply to comment #1)
> Created attachment 232513 [details]
> Patch
> 

I can't apply this patch (not with eclipse or with git am).  If you want to take another crack at it, you can push fixes to Gerrit - see http://wiki.eclipse.org/Platform_UI/How_to_Contribute and see http://wiki.eclipse.org/Platform-releng/Git_Workflows#Setting_up_your_repo #4 on how to add a review remote for pushing fixes to Gerrit.

PW
Comment 3 Nobody - feel free to take it CLA 2013-06-29 11:53:25 EDT
Created attachment 232917 [details]
Updated patch

This patch is against master. Hopefully it will work better.
Comment 4 Nobody - feel free to take it CLA 2013-07-15 14:36:22 EDT
Moved proposal to gerrit: https://git.eclipse.org/r/14572
Comment 6 Paul Webster CLA 2013-08-07 13:30:53 EDT
In 4.4.0.I20130806-2000

PW
Comment 7 Steven Spungin CLA 2014-04-05 23:11:47 EDT
This only works if filtering for a command that STARTS with the text one types.

Enter a space as the first character in quickaccess: All the commands that are disabled still appear in the previous choices.

To Reproduce:
Close A Project.
With the closed project selected, open the project using quickaccess
Now Close The Project
Select outside the project explorer
confirm the open project menu item is disabled.
type open in quickaccess -> it's true the item is not present
type a space in quickaccess -> there it is :)
type project in quickaccess -> there it is :)

now select the open project and enjoy the exception
Comment 8 Dani Megert CLA 2014-04-07 03:38:03 EDT
(In reply to Steven Spungin from comment #7)
> This only works if filtering for a command that STARTS with the text one
> types.
> 
> Enter a space as the first character in quickaccess: All the commands that
> are disabled still appear in the previous choices.
> 
> To Reproduce:
> Close A Project.
> With the closed project selected, open the project using quickaccess
> Now Close The Project
> Select outside the project explorer
> confirm the open project menu item is disabled.
> type open in quickaccess -> it's true the item is not present
> type a space in quickaccess -> there it is :)
> type project in quickaccess -> there it is :)
> 
> now select the open project and enjoy the exception

Steven, please file a new bug report with these steps, thanks.
Comment 9 Steven Spungin CLA 2014-04-07 04:19:26 EDT
Already did. Bug 432096