Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 393614 - Inappropriate "Import, open or create a new Project."
Summary: Inappropriate "Import, open or create a new Project."
Status: CLOSED FIXED
Alias: None
Product: Jubula
Classification: Technology
Component: UI (show other bugs)
Version: 1.3.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: Kepler   Edit
Assignee: Raimar Bühmann CLA
QA Contact: Oliver Goetz CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-05 17:26 EST by Ed Willink CLA
Modified: 2012-12-11 04:47 EST (History)
2 users (show)

See Also:


Attachments
Fix the bug by deleting the two useless markers shown in the problems view (6.96 KB, patch)
2012-12-05 05:34 EST, Raimar Bühmann CLA
no flags Details | Diff
Fix the bug by deleting the problems view markers including resolutions (14.88 KB, patch)
2012-12-06 03:28 EST, Raimar Bühmann CLA
markus.tiede: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Willink CLA 2012-11-05 17:26:05 EST
After installing Jubula I get a couple of Infos in the Problem View.

"Import, open or create a new Project."
"You have to connect to the AUT Agent."

Why do I want these when I'm not actually using Jubula?

Why is it necessary to search Bugzilla to discover that "AUT Agent" is a Jubula facility.? Surely "Jubula" should be mentioned in the "Type" description?
Comment 1 Alexandra Schladebeck CLA 2012-11-14 04:20:30 EST
I agree that the information isn't very useful when you're not using Jubula at the time. I haven't been able to find out whether problems view entries are supposed to be limited to the perspective / context for which they are valid - do you happen to know whether this is a UI guideline? 

If it's usually the case that problems view items are universal, then it would be worth adding Jubula as the type.
Comment 2 Ed Willink CLA 2012-11-14 04:33:47 EST
I've not seen perspective-filters problem markers, but I don't use Mylyn.

The intent is that markers are clearly annotated so that users filters can be applied; so regardless of other changes they should be annotated as Jubula markers.

Infos that are useful for developers during development should be removed prior to release.
Comment 3 Alexandra Schladebeck CLA 2012-11-19 08:29:02 EST
I had a look at the current setup in the problems view, and the entries do have the marker "Functional Test Problem" as a type designation. 

They are not remnants from development, but are there to give pointers about the first steps when beginning using Jubula. 

My tendency would be to either:
- talk about removing these two pieces of information completely (with the existence of the cheat sheets, hopefully people can find out themselves what the first steps are)
- leave them as they are, on the basis that "Functional Test Problem" can meaningfully be traced back to Jubula. 
- Switch the text "Functional Test Problem" to "Jubula" (this would involve making sure that we can change it to "GUIdancer" for GUIdancer users - the idea of "Functional Test" is that it is relevant to both tools).

What are your thoughts?
Comment 4 Ed Willink CLA 2012-11-19 08:46:14 EST
"Functional Test Problem" is a completely useless term. This all started because I assumed it was a new e4 report about some startup inconsistency.

Infos are a very poor way to guide users. THey lack focus and are niot necessarily visible. Just imagine if every Eclipse facility populated the Problem, view with every FAQ every written. 

- a welcome page entry is suitable for completely new users.
- a New Project..., or New... or Configure... entry are suitable for existing users.

My first choice is to remove them. With a clear Jubula as a second best.
Comment 5 Alexandra Schladebeck CLA 2012-11-27 05:47:46 EST
We've discussed that we're going to remove the two entries. The "First Steps" Cheat Sheets cover the necessary steps to get started, so these entries are no longer necessary.
Comment 6 Ed Willink CLA 2012-11-27 05:57:53 EST
Thanks.
Comment 7 Raimar Bühmann CLA 2012-12-05 05:34:18 EST
Created attachment 224303 [details]
Fix the bug by deleting the two useless markers shown in the problems view

The two useless messages

* "Import, open or create a new Project." and
* "You have to connect to the AUT Agent."

in the problem view are deleted including all associated code necessary to show these messages. This means the check for the connection and the two methods for showing the markers.
Comment 8 Markus Tiede CLA 2012-12-05 08:18:01 EST
I checked the provided patch and you still need to address the following issues:
 - these problem types have not been removed:
  - ProblemType.REASON_CONNECTED_TO_NO_SERVER
  - ProblemType.REASON_NO_PROJECT
 - and the code for the corresponding quickfixes has also not been removed

@Raimar: Could you please provide a patch which also addresses these necessary modifications and mark the current patch as obsolete?
Comment 9 Raimar Bühmann CLA 2012-12-06 03:28:25 EST
Created attachment 224354 [details]
Fix the bug by deleting the problems view markers including resolutions

In addition to comment 7: Also the resolutions offered by the problem markers are deleted:

- ProblemType.REASON_CONNECTED_TO_NO_SERVER
- ProblemType.REASON_NO_PROJECT
- and the code for the corresponding quickfixes
Comment 10 Markus Tiede CLA 2012-12-07 03:59:34 EST
Patch reviewed and applied with changeset

http://git.eclipse.org/c/jubula/org.eclipse.jubula.core.git/commit/?id=c918122a18889d41e096698caf63c175ab410156
Comment 11 Oliver Goetz CLA 2012-12-11 04:47:15 EST
Fix tested using current GD and Eclipse SDK 4.2.1 with Jubula feature from Jubula development update site.