This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 393460 - parentRequire.specified is undefined
Summary: parentRequire.specified is undefined
Status: RESOLVED WORKSFORME
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Editor (show other bugs)
Version: 1.0   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 2.0 M1   Edit
Assignee: Simon Kaegi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-02 16:21 EDT by Adam Peller CLA
Modified: 2012-12-07 14:55 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Peller CLA 2012-11-02 16:21:28 EDT 
When integrating the Orion editor with Maqetta, it is loaded by the Dojo loader.  parentRequire.specified is undefined, so the load() method in textview/i18n fails.  Our workaround is to simply test for truthiness:

if (parentRequire.specified && parentRequire.specified("orion/bootstrap")) { //$NON-NLS-0$
Comment 1 Simon Kaegi CLA 2012-11-05 10:00:52 EST 
Sorry Adam, that check was supposed to be in the code-base already.
Comment 2 Silenio Quarti CLA 2012-11-08 11:16:13 EST 
The test is already in the code base (Orion 1.0):

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=5cf156464601d5db223e11ad306e34fa42cd7ea2

Could it be a different problem?
Comment 3 Simon Kaegi CLA 2012-12-06 16:55:46 EST 
.
Comment 4 Simon Kaegi CLA 2012-12-06 16:56:24 EST 
.
Comment 5 Adam Peller CLA 2012-12-07 14:55:13 EST 
Sorry, I was looking at an old tag (v20120618-1815)