Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 392522 - some files in eclipseBuilder need to be "split stream" for HPUX 64 bit change
Summary: some files in eclipseBuilder need to be "split stream" for HPUX 64 bit change
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.3 M3   Edit
Assignee: David Williams CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 391273
  Show dependency tree
 
Reported: 2012-10-20 23:35 EDT by David Williams CLA
Modified: 2013-05-30 16:44 EDT (History)
0 users

See Also:


Attachments
text file listing relevent files (2.23 KB, text/plain)
2012-10-21 18:46 EDT, David Williams CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2012-10-20 23:35:02 EDT
These are changes related to bug 391273. See bug 392521 for other required changes handled via variables. 

In other cases, though, its easier, or required to duplicate a whole file in the "split stream" portion of maps project, instead of doing all the programming to use variables. Such files are maintained in a parallel structure, in 
/org.eclipse.releng/configuration/eclipseBuilderOverlays
and at build time, they are taken, depending on stream, and put over the main eclipseBuilder. 

The list of files that are known for this to be required are 

buildConfiguration.xml - org.eclipse.releng.eclipsebuilder/equinox/buildConfigs/osgistarter.config.launcher
customTargets.xml - org.eclipse.releng.eclipsebuilder/eclipse/buildConfigs/sdk (2 matches)
run.xml - org.eclipse.releng.eclipsebuilder/equinox/buildConfigs/equinox.prov (20 matches)
testManifest.xml - org.eclipse.releng.eclipsebuilder/eclipse/publishingFiles (6 matches)
testManifest.xml - org.eclipse.releng.eclipsebuilder/equinox/publishingFiles (2 matches)
Comment 1 David Williams CLA 2012-10-20 23:49:11 EDT
This is the initial commit, with files left in place, in eclipsebuilder, just to confirm all is working, again, and once that's done, need to move to maps project in parallel directory structure.
Comment 2 David Williams CLA 2012-10-20 23:49:41 EDT
(In reply to comment #1)
> This is the initial commit, with files left in place, in eclipsebuilder,
> just to confirm all is working, again, and once that's done, need to move to
> maps project in parallel directory structure.

Whoops: 

http://git.eclipse.org/c/platform/eclipse.platform.releng.eclipsebuilder.git/commit/?id=280f9987bbfc9ea2476e6ce271d135b4127750dd
Comment 3 David Williams CLA 2012-10-21 00:02:22 EDT
There remains these build.properties files. I _think_ in these values are no longer used by the build. Could be wrong, but ... just see oddities and inconsistencies, so I hate to perpetuate something in split stream that's not required. 

I'll start off leaving "as is", if that works in master branch, I think that's a strong sign not required, so then will consider (look again) as removing or setting to a more neutral value, e.g. configs=*,*,*

Advice welcome. 


build.properties - org.eclipse.releng.eclipsebuilder/eclipse/buildConfigs/master
build.properties - org.eclipse.releng.eclipsebuilder/eclipse/buildConfigs/org.eclipse.equinox.executable
build.properties - org.eclipse.releng.eclipsebuilder/eclipse/buildConfigs/pde.build.config.launcher (2 matches)
build.properties - org.eclipse.releng.eclipsebuilder/eclipse/buildConfigs/rcp.config (2 matches)
build.properties - org.eclipse.releng.eclipsebuilder/eclipse/buildConfigs/sdk (2 matches)
build.properties - org.eclipse.releng.eclipsebuilder/equinox/buildConfigs/osgistarter.config.launcher (2 matches)
Comment 4 David Williams CLA 2012-10-21 02:21:04 EDT
The build failed, so went ahead and changed all ia64_32 to ia64 in the build.properties files. At best it'd be an indirect explanation for error message but ... changing these back should get us back to point of where we were building.
Comment 6 David Williams CLA 2012-10-21 18:46:40 EDT
Created attachment 222619 [details]
text file listing relevent files

The attachment lists the files in eclipseBuilder that were moved to maps project, to the configuration/eclipseBuilderOverlays directory. 

Left commented files in eclipseBuilder so a) letter documented b) intentionally fail if I missed one, or system isn't working. 

In the attachment, it is handy to compare to see (and for me to double check) the parallel directory structure. 

The actual commit to eclipsebuilder was 
http://git.eclipse.org/c/platform/eclipse.platform.releng.eclipsebuilder.git/commit/?id=e38968ed552135093b666996ff13e66207dd2b0d

The commit to maps master was 
http://git.eclipse.org/c/platform/eclipse.platform.releng.maps.git/commit/?id=31f25f852539428aab57c6ecc38f4f3d93faec3f

Once I run this in an N build (as 18:45 today 10/21) and confirm its working, I'll put the corresponding (original) versions in the maintenance branches.
Comment 7 David Williams CLA 2012-10-21 22:12:50 EDT
The basics of the build (for 4.3 Nightly) seemed to work fine, so I went ahead and put the original files (with ia64_32) in the configuration/eclipseBuilderOverlays folder. 

I don't plan to test build M-builds early (since confident all is well) but ... next maintenance build deserves checking to make sure it still builds hpux ia64_32.
Comment 8 David Williams CLA 2013-05-30 16:44:46 EDT
mass change to 'verified', as these bugs are either routine or obviously fixed build breaks.