Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 392516 - config checks in runTests.sh and runTestsMac.sh seem unnecessary or too specific
Summary: config checks in runTests.sh and runTestsMac.sh seem unnecessary or too specific
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.3 M3   Edit
Assignee: David Williams CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-20 21:44 EDT by David Williams CLA
Modified: 2013-05-30 16:44 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2012-10-20 21:44:54 EDT
Admittedly, this "came to light" partially because I did not want to "split stream" these files for 

The mentioned scripts have some checks in them to "test input", such as 

# verify os, ws and arch values passed in are valid before running tests
if [ "$os-$ws-$arch" = "linux-gtk-x86" ] || [ "$os-$ws-$arch" = "macosx-cocoa-ppc" ] || [ "$os-$ws-$arch" = "macosx-cocoa-x86" ] || [ "$os-$ws-$arch" = "aix-gtk-ppc" ] || [ "$os-$ws-$arch" = "aix-gtk-ppc64" ]  || [ "$os-$ws-$arch" = "solaris-gtk-sparc" ] || [ "$os-$ws-$arch" = "solaris-gtk-x86" ] || [ "$os-$ws-$arch" = "linux-gtk-ppc64" ] ||  [ "$os-$ws-$arch" = "linux-gtk-ia64" ] ||  [ "$os-$ws-$arch" = "linux-gtk-x86_64" ] ||  [ "$os-$ws-$arch" = "hpux-gtk-ia64_32" ]

These don't seem that useful to me, in general, or at least too specific. I think we normally want our "test framework" to run testing anything ... even if certain configurations come and go as being "legal". 

I plan to remove it all together, for now, but if other think it is real important to detect typos early, or something, then please open a feature requests, and I think it'd be best to make more general, such as, in pseudo code

if $os is one of linux, macosx, aix (etc.) and 
if $ws is one of gtk, cocoa, etc. and 
if $arch is one of x86, ppc, ia64, ia64_32, etc. 

That way we would catch typing errors but I see little value in restricting whole framework to exactly one set of configurations. 

Feel free to disagree and explain what's important about this, if I have missed it.
Comment 2 David Williams CLA 2012-10-20 21:54:38 EDT
I see I forgot to finish my first sentence in comment 0. I meant 

... I did not want to "split stream" these files for bug 391273.
Comment 3 David Williams CLA 2013-05-30 16:44:19 EDT
mass change to 'verified', as these bugs are either routine or obviously fixed build breaks.