Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 392389 - Skip gtk_check_version for gtk 3.0+.
Summary: Skip gtk_check_version for gtk 3.0+.
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.3   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.3 M3   Edit
Assignee: Silenio Quarti CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 340067
  Show dependency tree
 
Reported: 2012-10-18 16:56 EDT by Alexander Kurtakov CLA
Modified: 2012-10-31 09:39 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kurtakov CLA 2012-10-18 16:56:05 EDT 
This will effectively allow trying to start against any major version of Gtk bigger than 3. Considering that it would be fairly hard work to compile/link against such version trying to run is not a problem. It's done this way because gtk_check_version returns false if the major version is different no matter higher or lower but we need a way to try running against multiple major version from the java side.

Commit/patch: http://fedorapeople.org/cgit/akurtakov/public_git/eclipse.platform.swt.git/commit/?h=gtk_check_version&id=ba4b859681ebeff75830fe419edf3d7cb2cbc6b1
Comment 1 Alexander Kurtakov CLA 2012-10-18 16:56:34 EDT 
Silenio, I would like to hear your opinion on that.
Comment 2 Silenio Quarti CLA 2012-10-19 10:06:50 EDT 
I do not see why this is necessary at this point. The code is just printing a warning to the console.  We need better checking once we are running GTK 3.
Comment 3 Alexander Kurtakov CLA 2012-10-19 13:54:17 EDT 
Well, I found it while trying to run stripped down swt on top of gtk3 and this bug is part of the initial errors and warnings I met. 
What better checks do you think of ?
Comment 4 Silenio Quarti CLA 2012-10-19 17:17:30 EDT 
I think we would call

   gtk_check_version(2, 10, 0)

when running against GTK2 (we are increase the version to 2.10 in Eclipse 4.3) and

   gtk_check_version(3, 0, 0)

when running against GTK3.  The exact GTK 3 version I am not sure yet. Do we actually run on 3.0.0?
Comment 5 Alexander Kurtakov CLA 2012-10-19 17:25:21 EDT 
I don't think we used anything thatrequires newer than 3.0.0. We do not run yet, there is still a lot of work to do. But we are getting closer.