Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 392251 - [TERMINALS] provide a standalone terminals feature
Summary: [TERMINALS] provide a standalone terminals feature
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Target (show other bugs)
Version: 1.1   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: 1.1   Edit
Assignee: Project Inbox CLA
QA Contact: Uwe Stieber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 402565
  Show dependency tree
 
Reported: 2012-10-17 19:04 EDT by Martin Oberhuber CLA
Modified: 2013-06-05 04:40 EDT (History)
0 users

See Also:


Attachments
Screenshot of install dialog (30.07 KB, image/gif)
2012-10-30 07:52 EDT, Martin Oberhuber CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2012-10-17 19:04:33 EDT
There are a number of adopters who consume the legacy TM Terminal feature in diverse environments. 

It would be good migrating them to the TE Terminals. For this, a "standalone" feature is needed with installs only the TE Terminal (and its connectors) but not the rest of the TE dependencies and CDT.
Comment 1 Uwe Stieber CLA 2012-10-27 06:48:28 EDT
Added o.e.tcf.te.terminals.feature and o.e.tcf.te.terminals.sdk.feature.

http://git.eclipse.org/c/tcf/org.eclipse.tcf.git/commit/?id=4ac13a65c01a4aeaeb08355ca99f915f1f84c736
Comment 2 Martin Oberhuber CLA 2012-10-29 12:30:15 EDT
Can you please expose the 2 new features on the TCF nightly update site:

http://download.eclipse.org/tools/tcf/builds/development/nightly

I suggest doing a new category "Terminal" with the 2 features below.
Comment 4 Martin Oberhuber CLA 2012-10-30 07:52:51 EDT
Created attachment 222974 [details]
Screenshot of install dialog

Looks good - but I have 2 more requests:

1. The "Terminal" category name is too broad when I have multiple repositories
   enabled. See attached screenshot. Maybe it's better moving the Terminals
   feature under the "Target Explorer" category after all.

2. I cannot install the "TE Terminals" feature when I do not have CDT (error
   below). Since cdt.core is a relatively "fat" plugin, I'm wondering whether
   that dependency could be avoided or made optional ?

----------------snip-install-error----------------
Cannot complete the install because one or more required items could not be found.
  Software being installed: Target Explorer Terminals 1.1.0.201210300939 (org.eclipse.tcf.te.terminals.feature.feature.group 1.1.0.201210300939)
  Missing requirement: Target Explorer, Terminals Process Connector 1.1.0.201209290902 (org.eclipse.tcf.te.ui.terminals.process 1.1.0.201209290902) requires 'bundle org.eclipse.cdt.core 5.4.0' but it could not be found
  Cannot satisfy dependency:
    From: Target Explorer Terminals 1.1.0.201210300939 (org.eclipse.tcf.te.terminals.feature.feature.group 1.1.0.201210300939)
    To: org.eclipse.tcf.te.ui.terminals.process [1.1.0.201209290902]
Comment 5 Martin Oberhuber CLA 2012-10-30 07:53:11 EDT
reopening to investigate cdt dependency
Comment 6 Martin Oberhuber CLA 2012-10-30 07:59:31 EDT
Also, when I install the "Terminals" feature only (allowing to pull its required dependencies from the TM and CDT repos), I do not see the Terminals View in Window > Show View.
Comment 7 Uwe Stieber CLA 2012-10-30 08:29:26 EDT
>I cannot install the "TE Terminals" feature when I do not have CDT (error
>below). Since cdt.core is a relatively "fat" plugin, I'm wondering whether
>that dependency could be avoided or made optional ?

Right, the processes connector is not a user connector. No need to bundle it with the standalone version. This removes the CDT dependency.

> I do not see the Terminals View in Window > Show View.

View shortcut is contributed to perspective targetID="*". Means it is available for all perspectives. Please run "Reset perspective" to make sure the perspective has revisted the shortcut definitions.

>The "Terminal" category name is too broad when I have multiple repositories >enabled.

Moved to "Target Explorer" category.
Comment 8 Martin Oberhuber CLA 2012-10-30 09:18:44 EDT
(In reply to comment #7)
> > I do not see the Terminals View in Window > Show View.
> 
> View shortcut is contributed to perspective targetID="*".

Hm... I'm afraid that this is too broad, it violates the concept of "peaceful coexistence" in products. View Shortcuts should be targeted for the workflows of a particular perspective. A Java or XML developer doesn't want or need a Terminals shortcut (even if he might have terminals installed for something else).

Right now, when I install the Terminals Feature only, I do not see the View under Window > Show View > Other ... likely because the View Category is missing.

I suggest making the View Category available, but avoid contributing Terminals to all Perspectives.
Comment 9 Martin Oberhuber CLA 2012-10-30 09:19:05 EDT
Reopen to address view shortcuts
Comment 10 Martin Oberhuber CLA 2012-10-30 09:21:49 EDT
Also, "Terminals" is currently contributed to the Java perspective by default. 
I don't think this is a good idea.