Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 391979 - Add tycho.scmUrl for eclipse.jdt.core.binaries.git
Summary: Add tycho.scmUrl for eclipse.jdt.core.binaries.git
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 4.2.1   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.8.2   Edit
Assignee: Jay Arthanareeswaran CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 389724
  Show dependency tree
 
Reported: 2012-10-15 15:05 EDT by Thanh Ha CLA
Modified: 2013-01-10 04:54 EST (History)
5 users (show)

See Also:

Attachments
eclipse.jdt.core.binaries.patch (403 bytes, patch)
2012-10-15 15:05 EDT, Thanh Ha CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thanh Ha CLA 2012-10-15 15:05:47 EDT 
Created attachment 222340 [details]
eclipse.jdt.core.binaries.patch

For Tycho to generate Eclipse-SourceReference headers a new property needs to be added to the pom ${tycho.scmUrl} for each repo.
Comment 1 Srikanth Sankaran CLA 2012-10-16 00:01:59 EDT 
Jay, please follow up, TIA
Comment 2 Stephan Herrmann CLA 2012-10-16 05:49:09 EDT 
eclipse.jdt.core.binaries is not intended for installation into the IDE, IIRC this is just a collection of (large) files used by tests.

Thus I don't see use in having a Eclipse-SourceReference here.
Am I missing anything?
Comment 3 Thanh Ha CLA 2012-10-16 09:26:43 EDT 
(In reply to comment #2)
> eclipse.jdt.core.binaries is not intended for installation into the IDE,
> IIRC this is just a collection of (large) files used by tests.
> 
> Thus I don't see use in having a Eclipse-SourceReference here.
> Am I missing anything?

We set in the eclipse-parent/pom.xml to tell Tycho to set Eclipse-SourceReference and Tycho requires this variable set to build or it will fail with the error below.

It would require some restructure of the pom files to tell Tycho which repositories specifically to build. Is there any issue with having this for a package that doesn't need it?


  [ERROR] Failed to execute goal org.eclipse.tycho:tycho-packaging-plugin:0.16.0-SNAPSHOT:package-plugin (default-package-plugin) on project org.eclipse.jdt.core.tests.binaries: Error assembling JAR: Eclipse-SourceReferences header should be generated but ${tycho.scmUrl} is not set -> [Help 1]
Comment 4 Thanh Ha CLA 2012-10-16 09:31:15 EDT 
I should have mentioned this should be applied to 3.8.2.
Comment 5 Stephan Herrmann CLA 2012-10-16 09:38:37 EDT 
(In reply to comment #3)
> (In reply to comment #2)
> > eclipse.jdt.core.binaries is not intended for installation into the IDE,
> > IIRC this is just a collection of (large) files used by tests.
> > 
> > Thus I don't see use in having a Eclipse-SourceReference here.
> > Am I missing anything?
> 
> We set in the eclipse-parent/pom.xml to tell Tycho to set
> Eclipse-SourceReference and Tycho requires this variable set to build or it
> will fail with the error below.
> 
> It would require some restructure of the pom files to tell Tycho which
> repositories specifically to build. Is there any issue with having this for
> a package that doesn't need it?

Not a problem, just it doesn't feel right if a tool forces us to do stupid things. I'd normally assume this header makes no sense for any of the test plugins, but I'll stop arguing here :)
Comment 6 Jay Arthanareeswaran CLA 2012-10-16 13:14:01 EDT 
Released the fix in master and R3_8_maintenance
Comment 7 Manoj N Palat CLA 2013-01-10 04:43:45 EST 
Verified for 4.2.2 M20130109-1200
Comment 8 Jay Arthanareeswaran CLA 2013-01-10 04:54:42 EST 
I have also verified that this indeed has been fixed in 4.3 M4.