Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 391978 - Add tycho.scmUrl for eclipse.jdt.core.git
Summary: Add tycho.scmUrl for eclipse.jdt.core.git
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 4.2.1   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.8.2   Edit
Assignee: Jay Arthanareeswaran CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 389724
  Show dependency tree
 
Reported: 2012-10-15 15:03 EDT by Thanh Ha CLA
Modified: 2012-10-30 12:04 EDT (History)
2 users (show)

See Also:

Attachments
eclipse.jdt.core.patch (423 bytes, patch)
2012-10-15 15:03 EDT, Thanh Ha CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thanh Ha CLA 2012-10-15 15:03:48 EDT 
Created attachment 222339 [details]
eclipse.jdt.core.patch

For Tycho to generate Eclipse-SourceReference headers a new property needs to be added to the pom ${tycho.scmUrl} for each repo.
Comment 1 Srikanth Sankaran CLA 2012-10-16 00:01:47 EDT 
Jay, please follow up.
Comment 2 Jay Arthanareeswaran CLA 2012-10-16 02:52:41 EDT 
Where does this fix go? The patch doesn't apply well on master.
Comment 3 Stephan Herrmann CLA 2012-10-16 05:50:57 EDT 
(In reply to comment #2)
> Where does this fix go? The patch doesn't apply well on master.

It's reported against 4.2.1, maybe that explains?
I assume this is part of LTS, right?
Comment 4 Thanh Ha CLA 2012-10-16 08:20:40 EDT 
(In reply to comment #3)
> (In reply to comment #2)
> > Where does this fix go? The patch doesn't apply well on master.
> 
> It's reported against 4.2.1, maybe that explains?
> I assume this is part of LTS, right?

This should go into master and R3_8_maintenance branches.

The patch just adds a property to the pom

<properties>
  <tycho.scmUrl>scm:git:git://git.eclipse.org/gitroot/jdt/eclipse.jdt.core.git</tycho.scmUrl>
</properties>


Looks like the reason it didn't apply cleanly is because master is missing a previous patch.

Master currently has this is the parent section:

  <parent>
    <groupId>org.eclipse</groupId>
    <artifactId>eclipse-parent</artifactId>
    <version>1.0.0-SNAPSHOT</version>
  </parent>

However there was a patch previously that should have added an extra line as follows:

  <parent>
    <groupId>org.eclipse</groupId>
    <artifactId>eclipse-parent</artifactId>
    <version>1.0.0-SNAPSHOT</version>
    <relativePath>../eclipse-parent</relativePath>
  </parent>

So in R3_8_maintenance branch the line relativePath is there but in master it's missing. This relativePath line should be added to master as well.
Comment 5 Thanh Ha CLA 2012-10-16 09:31:25 EDT 
I should have mentioned this should be applied to 3.8.2.
Comment 6 Jay Arthanareeswaran CLA 2012-10-16 09:33:46 EDT 
(In reply to comment #4)
> However there was a patch previously that should have added an extra line as
> follows:

My bad. I should have applied the fix for bug 383072 on master too. I have cherry-picked that commit now and applied this fix on top. Both commits have now been applied on master and R3_8_maintenance. 

Strangely, I had trouble applying the patch even then. May be because I did something wrong as I used command line - the file is outside the jdt/core projects and hence not part of my regular workspace.
Comment 7 Stephan Herrmann CLA 2012-10-30 12:03:41 EDT 
Verified for 4.3 M3 via code inspection that
- tycho.scmUrl is correctly set in master.

Filed bug 393166 for observations made along the road...