Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 391949 - Firefox pops up context menu on Ctrl-Space which is our content assist
Summary: Firefox pops up context menu on Ctrl-Space which is our content assist
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.5   Edit
Hardware: Macintosh Mac OS X
: P3 normal (vote)
Target Milestone: 3.0 M1   Edit
Assignee: Manu Sridharan CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-15 12:08 EDT by Ken Walker CLA
Modified: 2013-05-29 16:40 EDT (History)
2 users (show)

See Also:

Attachments
patch for the problem (1.16 KB, text/plain)
2013-04-11 12:47 EDT, Manu Sridharan CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ken Walker CLA 2012-10-15 12:08:36 EDT 
Using Firefox 16 on a Mac, if you use Ctrl-Space to try to get content assist, you also get a free context menu from Firefox.  The content assist menu is underneath.

Silenio said that contentAssist.js line#120 returns true to prevent the user agent key binding. But that is not working. Or at least Firefox is not honouring that override.
Comment 1 Manu Sridharan CLA 2013-04-11 12:47:15 EDT 
I ran into this very annoying issue as well.  After some digging, I think I found a patch that fixes it.  The idea is to detect when the 'contextmenu' event fires but the mouse button in the event is the main one (i.e., it's not a right-click), which I think indicates that the event originated with the CTRL+Space keyboard shortcut.  In this case, if we do a preventDefault, I think the right thing happens: CTRL+Space no longer brings up the Firefox context menu, but a right-click with the mouse does.  I'll attach my patch, which works for me.
Comment 2 Manu Sridharan CLA 2013-04-11 12:47:44 EDT 
Created attachment 229635 [details]
patch for the problem
Comment 3 Manu Sridharan CLA 2013-04-11 13:08:42 EDT 
Re: the patch:

I assert that I authored 100% of the content of this contribution and have the rights to donate the content to Eclipse under the EPL