Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 391596 - New File leaves gap when info message disappears
Summary: New File leaves gap when info message disappears
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.0 RC2   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-10 15:01 EDT by Ken Walker CLA
Modified: 2012-10-12 15:42 EDT (History)
1 user (show)

See Also:
ken_walker: review+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ken Walker CLA 2012-10-10 15:01:49 EDT
Go into a folder and choose "New File" Button.  Enter text and hit return.

Status message comes up saying "Creating [filename]" then the message goes away but the white space is left.

Refreshing the window is required to reclaim space.
Comment 1 Susan McCourt CLA 2012-10-10 16:48:47 EDT
Can you give me more specific steps - browser, the folder name, etc. etc.
This doesn't happen for me on Win7/chrome, so I suspect the steps are more specific than what you describe.
Comment 2 Ken Walker CLA 2012-10-11 13:52:41 EDT
Seems to be a non-issue on Chrome but is on Firefox and Safari.
Comment 3 Susan McCourt CLA 2012-10-11 14:18:37 EDT
will investigate
Comment 4 Susan McCourt CLA 2012-10-11 22:28:33 EDT
Ha, I found the logic error in our layout computation, and it fixes the problem but squishes everything upward on Chrome (not surprising, since Chrome doesn't exhibit the problem.)  Need to work on this more Friday.  I'm probably making a CSS positioning assumption that is not quite right...
Comment 5 Susan McCourt CLA 2012-10-12 13:04:15 EDT
Pushed to remote branch, please review and cherrypick/commit if you agree.
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=a461d2e256ce5d342235e2e59dbc7a42e367738f

The problem was that the code where we are establishing the original position of the content area under the toolbar was using the space between the parent and the content.  But this could be called when the slideout was already out, or worse, when the slideout or progress were activated but not yet filled in.  So we just kept adding extra space.  

The fix is to establish the position according to the toolbar bottom.
This assumes that nothing besides the slideout or notification area is between the toolbar and the content, but this is the code that's supposed to know about all that.  I added a comment in case we change this assumption later.

The change to status.js just reduces some duplicate and/or unneeded calls to the layout code.
Comment 6 Ken Walker CLA 2012-10-12 13:57:10 EDT
Looks good, but entered the following bug as well.

Bug 391819 - New File/Folder button after previous uses input area below failure message
Comment 7 Susan McCourt CLA 2012-10-12 15:42:43 EDT
pushed.