Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 391263 - Use gtk_render_focus instead of gtk_paint_focus for GTK+3
Summary: Use gtk_render_focus instead of gtk_paint_focus for GTK+3
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.3 M3   Edit
Assignee: Alexander Kurtakov CLA
QA Contact:
URL:
Whiteboard: gtk3test
Keywords:
Depends on:
Blocks: 340067
  Show dependency tree
 
Reported: 2012-10-05 14:52 EDT by Anatoly Spektor CLA
Modified: 2012-10-24 14:38 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anatoly Spektor CLA 2012-10-05 14:52:07 EDT 
This patch replaces gtk_paint_focus with gtk_render_focus for GTK+3 :

http://fedorapeople.org/cgit/aspektor/public_git/eclipse.platform.swt.git/commit/?h=gtk3_render_focus_64
Comment 1 Anatoly Spektor CLA 2012-10-05 14:55:54 EDT 
Implementation is based on: https://mail.gnome.org/archives/commits-list/2011-January/msg07745.html
Comment 2 Alexander Kurtakov CLA 2012-10-05 15:12:13 EDT 
Looks logically the same. Pushed to master. http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=077815f21f4c006f679f782063ec7af635ece7f2
Comment 3 Anatoly Spektor CLA 2012-10-05 16:53:33 EDT 
(In reply to comment #2)
> Looks logically the same. Pushed to master.
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=077815f21f4c006f679f782063ec7af635ece7f2

There is one mistake  version guard is 3,2 should be 3,0. Sorry for that!

I have revised my patch, new version is here:

http://fedorapeople.org/cgit/aspektor/public_git/eclipse.platform.swt.git/commit/?h=gtk3_render_focus_64
Comment 5 Arun Thondapu CLA 2012-10-15 08:11:29 EDT 
The version check wasn't fixed in GC.java, fixed it - http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=32e146465fbea87a81bbf86001a412945d162357