Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 391112 - GdkDragContext replaced by function calls.
Summary: GdkDragContext replaced by function calls.
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.3   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.3 M3   Edit
Assignee: Alexander Kurtakov CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 340067
  Show dependency tree
 
Reported: 2012-10-04 07:02 EDT by Alexander Kurtakov CLA
Modified: 2012-10-24 14:38 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kurtakov CLA 2012-10-04 07:02:42 EDT 
When struct is sealed we don't have access to the members directly so they have to be accessed via function calls.

Silenio, would you please review this patch? Especially the os.h part where I added defines to not have the memmove/sizeof compiled for GdkDragContext.
Comment 1 Alexander Kurtakov CLA 2012-10-04 07:04:30 EDT 
Also note that at one place I guarded things with Gtk 2.22 and on another with 3.0 because of functions being introduced in different versions.
Comment 3 Silenio Quarti CLA 2012-10-09 11:38:18 EDT 
Not sure why, but I cannot cherry-pick this commit. I get

fatal: The remote end hung up unexpectedly

The patch seems fine to me. I think we should guard against 3.0 instead of 2.22 in both places. Leave the GTK 2 case accessing the sealed fields.
Comment 4 Alexander Kurtakov CLA 2012-10-09 11:43:59 EDT 
(In reply to comment #3)
> Not sure why, but I cannot cherry-pick this commit. I get
> 
> fatal: The remote end hung up unexpectedly
> 
> The patch seems fine to me. I think we should guard against 3.0 instead of
> 2.22 in both places. Leave the GTK 2 case accessing the sealed fields.

Ok, I'll push it changed to guard against GTK 3. I've been trying to put the earliest guards in order to allow dropping binding for old apis more eagerly but I'm fine with your approach.
Fedorapeople git repo paths has changed so you might need to change the remote to git://fedorapeople.org/home/fedora/akurtakov/public_git/eclipse.platform.swt.git
Comment 5 Alexander Kurtakov CLA 2012-10-09 11:57:02 EDT 
Modified patch to not use sealed members only for Gtk 3.x+ pushed to master. http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=d035d311c7d866b11a51f8d6a8606684f71437d5