This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 391041 - Editor probably needs a destroy method
Summary: Editor probably needs a destroy method
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Editor (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 2.0 M1   Edit
Assignee: Silenio Quarti CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-03 12:05 EDT by Mark Macdonald CLA
Modified: 2012-12-07 10:32 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2012-10-03 12:05:42 EDT 
When an Editor needs to be destroyed, you're forced to call ditor.getTextView().destroy(). This is strange. The Editor should have its own destroy() that cleans up the TextView for you. We also need to investigate whether editor allocates resources (aside from the TextView) that should be freed.
Comment 1 Silenio Quarti CLA 2012-11-08 13:41:44 EST 
Added destroy() and uninstallTextView() APIs.  After destroy is called the editor instance should not be used any more. The uninstallTextView() API was added to be symmetrical to installTextView() API. It sends TextViewUninstalled event.  The editor text view can be installed/uninstalled multiple times.

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=2733cd6fed8629b9cc1a578e53992edba6da1478