Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 390891 - [1.8][compiler] JSR308 Grammar/Parser work: Follow up issues
Summary: [1.8][compiler] JSR308 Grammar/Parser work: Follow up issues
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.8   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: BETA J8   Edit
Assignee: Srikanth Sankaran CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 287648
  Show dependency tree
 
Reported: 2012-10-02 03:15 EDT by Srikanth Sankaran CLA
Modified: 2012-10-10 08:17 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Srikanth Sankaran CLA 2012-10-02 03:15:00 EDT 
BETA_JAVA8:

This is to track follow up issue to the redesign work:

    - One more round of (self) review.
    - Verify that for all changed methods in the Parser, subclass methods
      were also suitably modified.
    - Make sure that we reject annotations at all places where the grammar
      is over permissive.
    - Verify that HasTypeAnnotations bit is consistently set.
    - Coverage tests based on grammar rules.
    - Verify that all grammar rules have proper compliance.
    - All consume methods should have proper new rules updated in comments.
    - Verify that AssistParser handles type references correctly
Comment 2 Srikanth Sankaran CLA 2012-10-05 04:57:12 EDT 
The following items will be reviewed as part of code review 
for bug 383624 as these are really code generation concerns:

All instances of getAllAnnotationContexts
AnnotationContext
AnnotationTargetTypeConstants
AnnotationCollector
Annotation#getLocations
Annotation#isRuntimeInvisible
Annotation#isRuntimeVisible
Annotation#isRuntimeTypeInvisible
Annotation#isRuntimeTypeVisible
Comment 3 Srikanth Sankaran CLA 2012-10-05 11:11:21 EDT 
Pending activities on this bug:

    - Verify that for all changed methods in the Parser, subclass methods
      were also suitably modified.
    - Make sure that we reject annotations at all places where the grammar
      is over permissive.
    - Coverage tests based on grammar rules.
Comment 4 Srikanth Sankaran CLA 2012-10-07 04:06:21 EDT 
I have completed the code review and pending activities on this bug:

    - Coverage tests based on grammar rules.
    - One more round of spec review.
Comment 5 Srikanth Sankaran CLA 2012-10-10 08:17:11 EDT 
Added several tests for grammar coverage and spec review completed
too.

Resolving.