Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 389944 - improve patch set caching
Summary: improve patch set caching
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: 2.0   Edit
Assignee: Miles Parker CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-19 15:55 EDT by Sam Davis CLA
Modified: 2013-05-22 00:02 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Davis CLA 2012-09-19 15:55:06 EDT 
The downloading of patch set content should indicate its progress. It might also make sense to store the cache locally for some time so that it is not redownloaded every time the review is opened.
Comment 1 Steffen Pingel CLA 2012-09-19 17:48:33 EDT 
+1 Fetching the information into the Git repository would make the most sense from my perspective.
Comment 2 Miles Parker CLA 2012-11-09 19:37:00 EST 
Related to bug 394020.
Comment 3 Miles Parker CLA 2012-11-17 14:44:20 EST 
One other thought is that we do have all of this in the model. So as discussed in Mylyn call, we might consider making this part of a general solution in which the complete model is cached for each review with a review item set (one resource set per repos). I think this would be a relatively small amount of work and wouldn't actually require doing all of the work in bug 394020. Thoughts?
Comment 4 Miles Parker CLA 2013-03-08 20:04:27 EST 
See bug 400270 comment 9 and https://git.eclipse.org/r/#/c/11012/ for experimental implementation.
Comment 5 Miles Parker CLA 2013-04-25 22:18:44 EDT 
Tracking work under bug 394020. See https://git.eclipse.org/r/#/c/12229/ for early version of cache support.
Comment 6 Miles Parker CLA 2013-05-22 00:02:22 EDT 
Caching now works as of https://git.eclipse.org/r/#/c/12229/.

We may want to improve the progress notification and job management. If so, let's open a seperate bug.