Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 389937 - Use gtk_orientable_set_orientation and gtk_progressbar_set_inverted for GTK+ 3
Summary: Use gtk_orientable_set_orientation and gtk_progressbar_set_inverted for GTK+ 3
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.3 M3   Edit
Assignee: Alexander Kurtakov CLA
QA Contact:
URL:
Whiteboard: gtk3test
Keywords:
Depends on:
Blocks: 340067
  Show dependency tree
 
Reported: 2012-09-19 14:47 EDT by Anatoly Spektor CLA
Modified: 2012-10-04 15:01 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anatoly Spektor CLA 2012-09-19 14:47:33 EDT 
This patch replaces gtk_progressbar_set_orientation which is deprecated in GTK+3 and uses combination of gtk_orientable_set_orientation() and gtk_progressbar_set_inverted() for GTK+ 3 and higher:

http://fedorapeople.org/cgit/aspektor/public_git/eclipse.platform.swt.git/commit/?h=gtk3_progressbar_orientation


This patch is based on documentation:

http://developer.gnome.org/gtk3/3.3/ch25s02.html  
("GtkProgressBar orientation" section)
Comment 2 Alexander Kurtakov CLA 2012-10-03 14:58:56 EDT 
Patch looks good to me. GTK3 change only which we can't test for now. Pushed to master. http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=a025bf9445abd24cfb0807a29038b2face3f0f8a
Comment 3 Arun Thondapu CLA 2012-10-04 14:50:06 EDT 
Minor issue with the patch Alex, the switch case indentation is not according to SWT coding style.
Comment 4 Anatoly Spektor CLA 2012-10-04 15:01:09 EDT 
(In reply to comment #3)
> Minor issue with the patch Alex, the switch case indentation is not
> according to SWT coding style.

Thanks for noticing Arun!

 I have fixed formatting:

 http://fedorapeople.org/cgit/aspektor/public_git/eclipse.platform.swt.git/commit/?h=gtk3_progressbar_orientation_64