This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 389920 - perspective overlays portion of Welcome page after installing EGit
Summary: perspective overlays portion of Welcome page after installing EGit
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: Power PC AIX
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 391352 398923 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-09-19 13:17 EDT by Grant Gayed CLA
Modified: 2015-02-03 12:12 EST (History)
6 users (show)

See Also:
pwebster: review+


Attachments
screenshot (88.49 KB, image/jpeg)
2012-09-19 13:17 EDT, Grant Gayed CLA
no flags Details
Welcome page feature + plugin in an update site format (5.45 KB, application/zip)
2013-01-24 07:43 EST, Dave Nice CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Grant Gayed CLA 2012-09-19 13:17:02 EDT
Created attachment 221261 [details]
screenshot

4.3M2 test build

- use Help > Install New Software to install EGit and JGit from eclipse.org
- restart Eclipse
- when the workbench comes up it shows the Welcome page with the Git entry added, but also shows the initial perspective over top of much of it, which seems wrong
- screenshot is attached

I observed this on AIX and Solaris, but have not tried it on the other platforms.  If this does not happen on other platforms then the difference here could be that AIX and Solaris do not have usable Browser controls, which are used by the default Welcome page implementation.  OTOH if this happens on other platforms as well then this is likely not relevant.
Comment 1 Grant Gayed CLA 2012-09-19 13:19:12 EDT
I just realized that I said something wrong in comment 0, Solaris does have a working Browser control, so this is not related to whether there's a working Browser or not.
Comment 2 Eric Moffatt CLA 2012-09-19 14:19:48 EDT
I've seen this but only once. It appears that the workbench is activating the PackageExplorer (rather than or after it activates Welcome), causing the behavior.

I'll mark this for a look in SR2...
Comment 3 Curtis Windatt CLA 2012-12-12 13:02:46 EST
*** Bug 391352 has been marked as a duplicate of this bug. ***
Comment 4 Paul Webster CLA 2013-01-23 16:14:35 EST
*** Bug 398923 has been marked as a duplicate of this bug. ***
Comment 5 Dave Nice CLA 2013-01-23 16:22:52 EST
For future reference, bug 398923 has a simpleish recreate documented :-)
Comment 6 Dave Nice CLA 2013-01-24 07:43:25 EST
Created attachment 226039 [details]
Welcome page feature + plugin in an update site format

These are pretty basic, just following a combination of the new plug-in wizard (for the classes) and the help doc for extending the welcome page (for the xml files)
Comment 7 Dave Nice CLA 2013-01-24 07:44:02 EST
Recreated this reasonably reliably against M20120123-1200 on a few different machines.
Comment 8 Eric Moffatt CLA 2013-01-24 12:48:40 EST
Moving to 4.2.2...
Comment 9 Eric Moffatt CLA 2013-01-24 13:59:58 EST
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_2_maintenance&id=ddd6c7abe7a6013e5f5e92c528fe66e31cd79945

This is a surgical fix that simply prevents the PerspectiveStack from 'auto-opening' when one of its children changes state...not likely to be an issue under normal ops...

AAARGH!! I've already done the commit, now to ask for forgiveness...
Comment 10 Dave Nice CLA 2013-01-24 14:36:08 EST
Hey,

Patch seems good to me at first glance.

Did a bit of maximising windows and pinging minimised ones up and things seem generally hunky-dory, too.

Thank you!
Comment 11 John Arthorne CLA 2013-01-24 16:11:21 EST
Personally I would have deferred this one given it is RC3, but since it is already reviewed and released and a very surgical fix I am +1.
Comment 12 Eric Moffatt CLA 2013-01-25 11:25:41 EST
Thanks for the feedback Dave. I just waiting on some process work (approvals...) then I'll mark this as FIXED / VERIFIED.
Comment 13 Dave Nice CLA 2013-06-24 09:59:16 EDT
Hey - did you get far enough to mark this as fixed, yet?
Comment 14 Lars Vogel CLA 2015-02-03 12:12:23 EST
Fixed a while ago, sorry for the missing status update