Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 389760 - Local search: CTRL+F does not trigger find&replace any more on css files.
Summary: Local search: CTRL+F does not trigger find&replace any more on css files.
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.5   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 1.0 M2   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-17 16:04 EDT by libing wang CLA
Modified: 2012-09-17 17:02 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description libing wang CLA 2012-09-17 16:04:25 EDT 
Neither orion.eclipse.org nor my self hosting triggered find&replace param collector on *.css file any more.
Talked to Susan, she was able to do it in orion.eclipse.org but not on self hosting.
I remember I did a lot of search on ide.css last Thursday or Friday and it worked.
Comment 1 libing wang CLA 2012-09-17 16:27:57 EDT 
Hint:
theme.css worked fine on both orion.eclipse.org and self hosting.
Dunno why...
Comment 2 Susan McCourt CLA 2012-09-17 16:53:29 EDT 
it works for any CSS file *except* ide.css
Comment 3 Susan McCourt CLA 2012-09-17 17:02:23 EDT 
oh, this is kind of funny.
I go to all this trouble to make sure the outliner doesn't generate dom id's that conflict with other outliner items.  What does that have to do with this bug?  Well....

When you are editing ide.css your css outline contains the class ".pageNavigationActions" which is styling a span in the toolbar.  And that span in the toolbar is given the dom id "pageNavigationActions" as well as the class "pageNavigationActions".  Every page in orion has this span in the toolbar.  

But when you are editing ide.css, you end up with an outliner id that matches the id of the toolbar span "pageNavigationActions".  The code that tries to walk up the document to find the toolbar and slideout is starting from the outliner item rather than the toolbar span.

The fix is that when generating outline id's, make sure there's not already a dom element in that document with the proposed id, and if there is, then generate a unique one.

Fixed in http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=9c850fb2b745dfc29b002212ee4022b8b5a3c181