This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 389129 - Progress view background incorrect on 4.2
Summary: Progress view background incorrect on 4.2
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 4.4 M2   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-09 17:49 EDT by Alex Blewitt CLA
Modified: 2013-09-16 13:28 EDT (History)
2 users (show)

See Also:

Attachments
What the progress view looks like with no jobs running (with console for comparison) (64.43 KB, image/png)
2012-09-09 17:49 EDT, Alex Blewitt CLA 		no flags Details
What the progress view looks like with jobs running (console view for comparison) (99.19 KB, image/png)
2012-09-09 17:50 EDT, Alex Blewitt CLA 		no flags Details
proposed patch (1.09 KB, patch)
2013-06-26 11:06 EDT, Piotr Aniola CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Blewitt CLA 2012-09-09 17:49:32 EDT 
Created attachment 220873 [details]
What the progress view looks like with no jobs running (with console for comparison)

The progress view in Eclipse 4.2 is rendered with a grey background. However, the background of the Eclipse theme is white in 4.2, so this stands out like a sore thumb.

Furthermore, when jobs are running in Eclipse the background is shown as white. So depending on whether jobs are running or not, you get an alternating grey/white background.

This behaviour is seen on both OSX and Windows, so it's not a platform-specific bug.
Comment 1 Alex Blewitt CLA 2012-09-09 17:50:03 EDT 
Created attachment 220874 [details]
What the progress view looks like with jobs running (console view for comparison)
Comment 2 Alex Blewitt CLA 2012-09-09 18:00:32 EDT 
I think there's a difference between the list view and the widget background colours that are being set. When there's nothing showing, it has the widget background:

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/bundles/org.eclipse.ui.workbench/Eclipse%20UI/org/eclipse/ui/internal/progress/DetailedProgressViewer.java#n129


		Text noEntryLabel = new Text(noEntryArea, SWT.SINGLE);
		noEntryLabel.setText(ProgressMessages.ProgressView_NoOperations);
		noEntryLabel.setBackground(noEntryArea.getDisplay().getSystemColor(
				SWT.COLOR_WIDGET_BACKGROUND));

When there's a list, it's showing the list background:

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/bundles/org.eclipse.ui.workbench/Eclipse%20UI/org/eclipse/ui/internal/progress/DetailedProgressViewer.java#n74

		control.setBackground(parent.getDisplay().getSystemColor(
				SWT.COLOR_LIST_BACKGROUND));

I suspect the alternating colours might be do do with these two choices. I'd argue that the 'no jobs' case is actually a list with no elements, so should adopt the list background and not the widget background.
Comment 3 Piotr Aniola CLA 2013-06-26 11:06:36 EDT 
Created attachment 232802 [details]
proposed patch
Comment 4 Eric Moffatt CLA 2013-09-13 13:42:38 EDT 
Committed:

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=8c9793946e4604da4832b71ed6150358f5f4498e

Which implements Piotr's patch, thanks...
Comment 5 Eric Moffatt CLA 2013-09-16 13:28:44 EDT 
Verified in 4.4.0.I20130915-2000.