Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 389041 - Unify git credentials storage and preference storage
Summary: Unify git credentials storage and preference storage
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 1.0 RC1   Edit
Assignee: Maciej Bendkowski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-07 07:51 EDT by Maciej Bendkowski CLA
Modified: 2012-09-27 05:56 EDT (History)
3 users (show)

See Also:
maciej.bendkowski: review? (malgorzata.tomczyk)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Bendkowski CLA 2012-09-07 07:51:53 EDT 
Since git credentials storage does not provide any encryption so far, there is no reason to have two separate storages for custom preferences. The suggestion came from bug 388927.
Comment 3 Ken Walker CLA 2012-09-24 10:34:40 EDT 
This still needs reviewing
Comment 4 Malgorzata Janczarska CLA 2012-09-26 12:28:11 EDT 
Generally this works and looks good. The only thing is that John has corrected some strings of yours that caused conflict. Please rebase the commit and double check for the messages you display.
Comment 5 Maciej Bendkowski CLA 2012-09-27 04:08:30 EDT 
(In reply to comment #4)
> Generally this works and looks good. The only thing is that John has
> corrected some strings of yours that caused conflict. Please rebase the
> commit and double check for the messages you display.

Done as requested. Please review the following fix: https://orion.eclipse.org/git/reviewRequest.html#git@github.com:maciej-bendkowski/orion.client.git_9077c8d8f863560367f6f5ad0c2e358aa0342726
Comment 6 Malgorzata Janczarska CLA 2012-09-27 05:56:22 EDT 
Pushed, thanks Maciek!