Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 388991 - Use gtk_render_frame_gap instead of gtk_paint_box_gap for GTK+ 3
Summary: Use gtk_render_frame_gap instead of gtk_paint_box_gap for GTK+ 3
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.3 M3   Edit
Assignee: Alexander Kurtakov CLA
QA Contact:
URL:
Whiteboard: gtk3test
Keywords:
Depends on:
Blocks: 340067
  Show dependency tree
 
Reported: 2012-09-06 15:41 EDT by Anatoly Spektor CLA
Modified: 2012-10-24 14:38 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anatoly Spektor CLA 2012-09-06 15:41:38 EDT 
This patch omits use of deprecated gtk_paint_box_gap () method and uses GTK+3 API method instead:




http://fedorapeople.org/cgit/aspektor/public_git/eclipse.platform.swt.git/commit/?h=gtk3_render_frame_gap&id=fc69b019c6a5e7af13d04ebecdc6a7d321535924
Comment 1 Silenio Quarti CLA 2012-10-01 11:07:31 EDT 
This patch leaks the cairo context created in TabFolderDrawData.gtk_render_box_gap().
Comment 2 Anatoly Spektor CLA 2012-10-05 13:57:10 EDT 
(In reply to comment #1)
> This patch leaks the cairo context created in
> TabFolderDrawData.gtk_render_box_gap().

Thank you again for pointing that out!

64-bit revised version of the patch is available here:

http://fedorapeople.org/cgit/aspektor/public_git/eclipse.platform.swt.git/commit/?h=gtk3_render_frame_gap_64
Comment 3 Alexander Kurtakov CLA 2012-10-05 14:34:30 EDT 
Thanks for the patch. Pushed to master. http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=d20287fc0028770d688fd3fc76eadc9c310edecb