Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 388927 - Some extra comments for Saving Git Credentials feature
Summary: Some extra comments for Saving Git Credentials feature
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 1.0 M2   Edit
Assignee: Maciej Bendkowski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-06 07:44 EDT by Szymon Brandys CLA
Modified: 2012-09-18 07:00 EDT (History)
1 user (show)

See Also:
malgorzata.tomczyk: review+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Brandys CLA 2012-09-06 07:44:20 EDT
1. I would merge gitCredentialsStorage with the pref storage we already use. I remember the rational why we created our own storage, mostly related to encrypting keys, but now I think we can just the current pref store.
2. Looks like some keys in messages.js are left unreferenced
3. You added LabelledRepositoryLinks.js to client.core and client.core should have more generic classes/names and do not mention repositories etc.
4. The "Erase Key" link should be a command from the command framework
5. Items in Git Credentials and Linked Accounts should look the same (ie [label][space][actions]), this is probably a separate bug
6. Some minor wording changes 
"Git Credentials" -> "Git Credentials Storage"
"Enable Key Storage" -> "Enable Storage"
remove "Authentication"
Comment 1 Maciej Bendkowski CLA 2012-09-07 07:47:34 EDT
Fix: https://orion.eclipse.org/git/reviewRequest.html#git@github.com:maciej-bendkowski/orion.client.git_b1cf3dc571ffcb24e9be1555c07efb360e8d17b3

For points 1) and 5) I will raise separate bugs.
Comment 2 Maciej Bendkowski CLA 2012-09-17 04:06:11 EDT
Since Szymon is on vacation, Gosia, please review for him.
Comment 4 Malgorzata Janczarska CLA 2012-09-18 07:00:21 EDT
Pushed, thanks Maciek.
Please watch the status of 1) and 5).