Community
Participate
Working Groups
1. I would merge gitCredentialsStorage with the pref storage we already use. I remember the rational why we created our own storage, mostly related to encrypting keys, but now I think we can just the current pref store. 2. Looks like some keys in messages.js are left unreferenced 3. You added LabelledRepositoryLinks.js to client.core and client.core should have more generic classes/names and do not mention repositories etc. 4. The "Erase Key" link should be a command from the command framework 5. Items in Git Credentials and Linked Accounts should look the same (ie [label][space][actions]), this is probably a separate bug 6. Some minor wording changes "Git Credentials" -> "Git Credentials Storage" "Enable Key Storage" -> "Enable Storage" remove "Authentication"
Fix: https://orion.eclipse.org/git/reviewRequest.html#git@github.com:maciej-bendkowski/orion.client.git_b1cf3dc571ffcb24e9be1555c07efb360e8d17b3 For points 1) and 5) I will raise separate bugs.
Since Szymon is on vacation, Gosia, please review for him.
Rebased fix: https://orion.eclipse.org/git/reviewRequest.html#git@github.com:maciej-bendkowski/orion.client.git_149bc004bdb117bc1052006f90750731921dcce6
Pushed, thanks Maciek. Please watch the status of 1) and 5).