Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 388869 - Use gtk_render_layout() instead of gtk_paint_layout() for GTK+3 and higher
Summary: Use gtk_render_layout() instead of gtk_paint_layout() for GTK+3 and higher
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.3 M3   Edit
Assignee: Alexander Kurtakov CLA
QA Contact:
URL:
Whiteboard: gtk3test
Keywords:
Depends on:
Blocks: 340067
  Show dependency tree
 
Reported: 2012-09-05 14:01 EDT by Anatoly Spektor CLA
Modified: 2012-10-24 14:38 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anatoly Spektor CLA 2012-09-05 14:01:38 EDT 
This patch implements GTK+ 3 API method gtk_render_layout() instead of deprecated gtk_paint_layout() for GTK+ 3 and higher:

http://fedorapeople.org/cgit/aspektor/public_git/eclipse.platform.swt.git/commit/?h=gtk3_render_layout
Comment 1 Silenio Quarti CLA 2012-10-01 11:20:10 EDT 
This patch leaks a cairo context.
Comment 2 Anatoly Spektor CLA 2012-10-05 10:08:44 EDT 
(In reply to comment #1)
> This patch leaks a cairo context.

Thank you for pointing that out!

Here is revised 64-bit patch:

http://fedorapeople.org/cgit/aspektor/public_git/eclipse.platform.swt.git/commit/?h=gtk3_render_layout_64
Comment 3 Anatoly Spektor CLA 2012-10-05 11:26:59 EDT 
(In reply to comment #2)
> (In reply to comment #1)
> > This patch leaks a cairo context.
> 
> Thank you for pointing that out!
> 
> Here is revised 64-bit patch:
> 
> http://fedorapeople.org/cgit/aspektor/public_git/eclipse.platform.swt.git/
> commit/?h=gtk3_render_layout_64

I have also removed cairo_t cast to ensure RHEL 4 compatibility. Please refer to the patch above.
Comment 4 Alexander Kurtakov CLA 2012-10-05 13:04:06 EDT 
Thanks for all the changes. Pushed to master. http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=fced94f9eb057f73fb291e17160f948c0221a298