Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 388778 - Use gtk_render_line() instead of gtk_paint_vline and gtk_paint_hline for GTK+3
Summary: Use gtk_render_line() instead of gtk_paint_vline and gtk_paint_hline for GTK+3
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.3 M3   Edit
Assignee: Alexander Kurtakov CLA
QA Contact:
URL:
Whiteboard: gtk3test
Keywords:
Depends on:
Blocks: 340067
  Show dependency tree
 
Reported: 2012-09-04 14:02 EDT by Anatoly Spektor CLA
Modified: 2012-10-08 07:52 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anatoly Spektor CLA 2012-09-04 14:02:53 EDT 
This patch uses gtk_render_line () for GTK3+ instead of gtk_paint_hline() and gtk_paint_vline().

 As gtk_render_line () receives one extra argument (it has x0 y0 x1 and y1, however old API has only three arguments depending on the dimension), my proposal is to to give same coordinates (meaning y0 = y1 when drawing horizontal line, x0=x1 when drawing vertical line) to gtk_render_line() thus it will draw line only in dimension needed.

 Here is the patch:

http://fedorapeople.org/cgit/aspektor/public_git/eclipse.platform.swt.git/commit/?h=gtk3_render_line

If there are any concerns about it, please let me know.
Comment 1 Anatoly Spektor CLA 2012-10-04 13:18:05 EDT 
64-bit revised version available from here:

http://fedorapeople.org/cgit/aspektor/public_git/eclipse.platform.swt.git/commit/?h=gtk3_render_line_64