Community
Participate
Working Groups
git-log is the only page left that is not consistent with our new look&feel. We need to make it look more like other Git pages, especially git-status2 where we already have selection model added.
Created attachment 220974 [details] Quick preview 1 In the attachment you may find a preview of the current view of the new git-log2. I tried to make it as much consistent with the other sites as possible. Szymon, Gosia and Susan, I'd to you to take a look and share your thoughts on the directions this is going to.
Created attachment 220975 [details] Quick preview 2 Another think I'd like to discuss is if and where to put the branches information and the tag information both present on the old git-log page. I tried to make the commit row higher and put those information there, like the repository 'unstaged files' and 'commits to push' on the repository page. Unfortunately this does not look good at all. 50 items per page causes the user to scroll a lot in this situation. I don't see any place for the branches and tags information in the commit row, so maybe we could insert them into the commit dialog. Unfortunately it won't be possible to detect connected branches and tags in a quick manner like it is with a table view right now. Does anyone has any ideas how to arrange these items on the new view?
Created attachment 220988 [details] commit hover idea (In reply to comment #1) >Szymon, Gosia and Susan, I'd to you to take a look and share your > thoughts on the directions this is going to. I really like the direction, much more slick and not so "table-ish". But I immediately wondered your next question...where the tag and branches info will go. I agree with the idea of putting it in the popup hover dialog. Attaching a screenshot. The idea is to move the "commit" and "parent" details to the bottom and then add "branches" and "tags" and then align the headings and content in a more tabular format. I suppose if there are multiple branches/headings they would stack vertically underneath...
Created attachment 221141 [details] Commit tooltip preview Fix: https://orion.eclipse.org/git/reviewRequest.html#git@github.com:maciej-bendkowski/orion.client.git_850580f815878144db2e93b4c7d031f248f3747e I enclose a preview of the commit tooltip UI update. I decided to tweak a bit the Susan proposal to make use of the horizontal whitespace, so now the tags and branches are displayed in max. two columns. This way the commit tooltip is in my opinion much more compact.
Created attachment 221285 [details] Commit tooltip layout The commit tooltip have a strange layout, up to some point it has a margin of width of the user picture and then the margins is not applied for the last information (usually branches or tags). I suggest one way or another.
The Related pages are missing and the breadcrumb has links to git-log.html instead of git-log2.html.
(In reply to comment #6) > The Related pages are missing and the breadcrumb has links to git-log.html > instead of git-log2.html. This error is thrown, it may have something to do with missing Related: TypeError: commandService is undefined [Break On This Error] command = commandService.findCommand(info.id); globalCommands.js (line 404)
All comments should be fixed in: https://orion.eclipse.org/git/reviewRequest.html#git@github.com:maciej-bendkowski/orion.client.git_258404c36ac95c47a422c069332d4c2a07e77cb7
On Gosia's request I've changed the UI: https://orion.eclipse.org/git/reviewRequest.html#git@github.com:maciej-bendkowski/orion.client.git_4570205be49d5feedec7f5d7701a569996a86ab7
Merge action on Remote Branch: TypeError: dojo.hitch(explorer, explorer.changedItem) is not a function ()gitCommands.js (line 1080) notify()Deferred.js (line 216) ()Deferred.js (line 25) complete()Deferred.js (line 203) ()Deferred.js (line 245) ()xhr.js (line 772) ()xhr.js (line 655) ()xhr.js (line 674) dojo.hitch(explorer, explorer.changedItem)(item); gitCommands.js (line 1080)
Compare With Working Tree action is present on git log and I think it shouldn't.
Still something is not right with Related pages, git log 1 has links to Status, Log, Repository, Navigator and optionally to GitHub and git log 2 has only Log and Repository.
(In reply to comment #10) > Merge action on Remote Branch: > TypeError: dojo.hitch(explorer, explorer.changedItem) is not a function I see the same problem on Push All command in git log, gitCommands.js (line 1339)
Please review the following fix: https://orion.eclipse.org/git/reviewRequest.html#git@github.com:maciej-bendkowski/orion.client.git_4731d76da12160ef49b972f29b5f961b1be17ed9
This fix looks good. I'll commit it when we have master open.
Pushed as git-log2.
